From: Jason Dillaman Date: Thu, 6 Sep 2018 21:08:12 +0000 (-0400) Subject: librbd: use the correct error code when the exclusive lock isn't locked X-Git-Tag: v14.0.1~228^2 X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F23829%2Fhead;p=ceph.git librbd: use the correct error code when the exclusive lock isn't locked If the client is currently blacklisted, use -EBLACKLISTED, otherwise use -EROFS. Signed-off-by: Jason Dillaman --- diff --git a/src/librbd/DeepCopyRequest.cc b/src/librbd/DeepCopyRequest.cc index 0813b580c92cc..a522ceee246aa 100644 --- a/src/librbd/DeepCopyRequest.cc +++ b/src/librbd/DeepCopyRequest.cc @@ -201,14 +201,15 @@ void DeepCopyRequest::send_copy_object_map() { ldout(m_cct, 20) << dendl; Context *finish_op_ctx = nullptr; + int r; if (m_dst_image_ctx->exclusive_lock != nullptr) { - finish_op_ctx = m_dst_image_ctx->exclusive_lock->start_op(); + finish_op_ctx = m_dst_image_ctx->exclusive_lock->start_op(&r); } if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; m_dst_image_ctx->snap_lock.put_read(); m_dst_image_ctx->owner_lock.put_read(); - finish(-EROFS); + finish(r); return; } @@ -235,16 +236,17 @@ void DeepCopyRequest::handle_copy_object_map(int r) { template void DeepCopyRequest::send_refresh_object_map() { + int r; Context *finish_op_ctx = nullptr; { RWLock::RLocker owner_locker(m_dst_image_ctx->owner_lock); if (m_dst_image_ctx->exclusive_lock != nullptr) { - finish_op_ctx = m_dst_image_ctx->exclusive_lock->start_op(); + finish_op_ctx = m_dst_image_ctx->exclusive_lock->start_op(&r); } } if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } diff --git a/src/librbd/ExclusiveLock.cc b/src/librbd/ExclusiveLock.cc index c2b2ef00364ee..ba3591fb904e6 100644 --- a/src/librbd/ExclusiveLock.cc +++ b/src/librbd/ExclusiveLock.cc @@ -137,11 +137,12 @@ void ExclusiveLock::handle_peer_notification(int r) { } template -Context *ExclusiveLock::start_op() { +Context *ExclusiveLock::start_op(int* ret_val) { ceph_assert(m_image_ctx.owner_lock.is_locked()); Mutex::Locker locker(ML::m_lock); if (!accept_ops(ML::m_lock)) { + *ret_val = get_unlocked_op_error(); return nullptr; } diff --git a/src/librbd/ExclusiveLock.h b/src/librbd/ExclusiveLock.h index 3c5ebab33a38d..8b2a411f44232 100644 --- a/src/librbd/ExclusiveLock.h +++ b/src/librbd/ExclusiveLock.h @@ -24,14 +24,13 @@ public: void block_requests(int r); void unblock_requests(); - int get_unlocked_op_error() const; - void init(uint64_t features, Context *on_init); void shut_down(Context *on_shutdown); void handle_peer_notification(int r); - Context *start_op(); + int get_unlocked_op_error() const; + Context *start_op(int* ret_val); protected: void shutdown_handler(int r, Context *on_finish) override; diff --git a/src/librbd/Operations.cc b/src/librbd/Operations.cc index 4940bffd9a0b2..43d96a852d773 100644 --- a/src/librbd/Operations.cc +++ b/src/librbd/Operations.cc @@ -227,14 +227,15 @@ struct C_InvokeAsyncRequest : public Context { ldout(cct, 20) << __func__ << ": r=" << r << dendl; if (r < 0) { - complete(-EROFS); + complete(r == -EBLACKLISTED ? -EBLACKLISTED : -EROFS); return; } // context can complete before owner_lock is unlocked RWLock &owner_lock(image_ctx.owner_lock); owner_lock.get_read(); - if (image_ctx.exclusive_lock->is_lock_owner()) { + if (image_ctx.exclusive_lock == nullptr || + image_ctx.exclusive_lock->is_lock_owner()) { send_local_request(); owner_lock.put_read(); return; @@ -801,7 +802,7 @@ int Operations::snap_rollback(const cls::rbd::SnapshotNamespace& snap_namespa r = prepare_image_update(false); if (r < 0) { - return -EROFS; + return r; } execute_snap_rollback(snap_namespace, snap_name, prog_ctx, &cond_ctx); @@ -1374,7 +1375,7 @@ int Operations::update_features(uint64_t features, bool enabled) { RWLock::RLocker owner_lock(m_image_ctx.owner_lock); r = prepare_image_update(true); if (r < 0) { - return -EROFS; + return r; } execute_update_features(features, enabled, &cond_ctx, 0); @@ -1496,10 +1497,6 @@ int Operations::metadata_remove(const std::string &key) { CephContext *cct = m_image_ctx.cct; ldout(cct, 5) << this << " " << __func__ << ": key=" << key << dendl; - if (m_image_ctx.read_only) { - return -EROFS; - } - int r = m_image_ctx.state->refresh_if_required(); if (r < 0) { return r; @@ -1673,11 +1670,14 @@ int Operations::prepare_image_update(bool request_lock) { m_image_ctx.exclusive_lock->unblock_requests(); } + if (r == -EAGAIN || r == -EBUSY) { + r = 0; + } if (r < 0) { return r; } else if (m_image_ctx.exclusive_lock != nullptr && !m_image_ctx.exclusive_lock->is_lock_owner()) { - return -EROFS; + return m_image_ctx.exclusive_lock->get_unlocked_op_error(); } return 0; diff --git a/src/librbd/deep_copy/ObjectCopyRequest.cc b/src/librbd/deep_copy/ObjectCopyRequest.cc index b363b57c8f3fd..9f1ff8ac43343 100644 --- a/src/librbd/deep_copy/ObjectCopyRequest.cc +++ b/src/librbd/deep_copy/ObjectCopyRequest.cc @@ -376,14 +376,15 @@ void ObjectCopyRequest::send_write_object() { return; } + int r; Context *finish_op_ctx; { RWLock::RLocker owner_locker(m_dst_image_ctx->owner_lock); - finish_op_ctx = start_lock_op(m_dst_image_ctx->owner_lock); + finish_op_ctx = start_lock_op(m_dst_image_ctx->owner_lock, &r); } if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } @@ -392,8 +393,8 @@ void ObjectCopyRequest::send_write_object() { finish_op_ctx->complete(0); }); librados::AioCompletion *comp = create_rados_callback(ctx); - int r = m_dst_io_ctx.aio_operate(m_dst_oid, comp, &op, dst_snap_seq, - dst_snap_ids, nullptr); + r = m_dst_io_ctx.aio_operate(m_dst_oid, comp, &op, dst_snap_seq, dst_snap_ids, + nullptr); ceph_assert(r == 0); comp->release(); } @@ -454,12 +455,13 @@ void ObjectCopyRequest::send_update_object_map() { ldout(m_cct, 20) << "dst_snap_id=" << dst_snap_id << ", object_state=" << static_cast(object_state) << dendl; - auto finish_op_ctx = start_lock_op(m_dst_image_ctx->owner_lock); + int r; + auto finish_op_ctx = start_lock_op(m_dst_image_ctx->owner_lock, &r); if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; m_dst_image_ctx->snap_lock.put_read(); m_dst_image_ctx->owner_lock.put_read(); - finish(-EROFS); + finish(r); return; } @@ -494,12 +496,12 @@ void ObjectCopyRequest::handle_update_object_map(int r) { } template -Context *ObjectCopyRequest::start_lock_op(RWLock &owner_lock) { +Context *ObjectCopyRequest::start_lock_op(RWLock &owner_lock, int* r) { ceph_assert(m_dst_image_ctx->owner_lock.is_locked()); if (m_dst_image_ctx->exclusive_lock == nullptr) { return new FunctionContext([](int r) {}); } - return m_dst_image_ctx->exclusive_lock->start_op(); + return m_dst_image_ctx->exclusive_lock->start_op(r); } template diff --git a/src/librbd/deep_copy/ObjectCopyRequest.h b/src/librbd/deep_copy/ObjectCopyRequest.h index 090f42ffc00cc..4b3f88e1fc6c7 100644 --- a/src/librbd/deep_copy/ObjectCopyRequest.h +++ b/src/librbd/deep_copy/ObjectCopyRequest.h @@ -176,7 +176,7 @@ private: void send_update_object_map(); void handle_update_object_map(int r); - Context *start_lock_op(RWLock &owner_lock); + Context *start_lock_op(RWLock &owner_lock, int* r); uint64_t src_to_dst_object_offset(uint64_t objectno, uint64_t offset); diff --git a/src/librbd/deep_copy/SetHeadRequest.cc b/src/librbd/deep_copy/SetHeadRequest.cc index ae110f47650ba..a5cf9059a7c9c 100644 --- a/src/librbd/deep_copy/SetHeadRequest.cc +++ b/src/librbd/deep_copy/SetHeadRequest.cc @@ -57,10 +57,11 @@ void SetHeadRequest::send_set_size() { librados::ObjectWriteOperation op; librbd::cls_client::set_size(&op, m_size); - auto finish_op_ctx = start_lock_op(); + int r; + auto finish_op_ctx = start_lock_op(&r); if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } @@ -69,7 +70,7 @@ void SetHeadRequest::send_set_size() { finish_op_ctx->complete(0); }); librados::AioCompletion *comp = create_rados_callback(ctx); - int r = m_image_ctx->md_ctx.aio_operate(m_image_ctx->header_oid, comp, &op); + r = m_image_ctx->md_ctx.aio_operate(m_image_ctx->header_oid, comp, &op); ceph_assert(r == 0); comp->release(); } @@ -113,10 +114,12 @@ void SetHeadRequest::send_detach_parent() { m_image_ctx->parent_lock.put_read(); ldout(m_cct, 20) << dendl; - auto finish_op_ctx = start_lock_op(); + + int r; + auto finish_op_ctx = start_lock_op(&r); if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } @@ -160,10 +163,12 @@ void SetHeadRequest::send_attach_parent() { m_image_ctx->parent_lock.put_read(); ldout(m_cct, 20) << dendl; - auto finish_op_ctx = start_lock_op(); + + int r; + auto finish_op_ctx = start_lock_op(&r); if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } @@ -197,12 +202,12 @@ void SetHeadRequest::handle_attach_parent(int r) { } template -Context *SetHeadRequest::start_lock_op() { +Context *SetHeadRequest::start_lock_op(int* r) { RWLock::RLocker owner_locker(m_image_ctx->owner_lock); if (m_image_ctx->exclusive_lock == nullptr) { return new FunctionContext([](int r) {}); } - return m_image_ctx->exclusive_lock->start_op(); + return m_image_ctx->exclusive_lock->start_op(r); } template diff --git a/src/librbd/deep_copy/SetHeadRequest.h b/src/librbd/deep_copy/SetHeadRequest.h index 3b9fab7a73bb1..9a17c9fd01cbf 100644 --- a/src/librbd/deep_copy/SetHeadRequest.h +++ b/src/librbd/deep_copy/SetHeadRequest.h @@ -74,7 +74,7 @@ private: void send_attach_parent(); void handle_attach_parent(int r); - Context *start_lock_op(); + Context *start_lock_op(int* r); void finish(int r); }; diff --git a/src/librbd/deep_copy/SnapshotCopyRequest.cc b/src/librbd/deep_copy/SnapshotCopyRequest.cc index 68da4e6ef1377..b8947d733f74f 100644 --- a/src/librbd/deep_copy/SnapshotCopyRequest.cc +++ b/src/librbd/deep_copy/SnapshotCopyRequest.cc @@ -174,10 +174,11 @@ void SnapshotCopyRequest::send_snap_unprotect() { ldout(m_cct, 20) << "snap_name=" << m_snap_name << ", " << "snap_id=" << m_prev_snap_id << dendl; - auto finish_op_ctx = start_lock_op(); + int r; + auto finish_op_ctx = start_lock_op(&r); if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } @@ -270,10 +271,11 @@ void SnapshotCopyRequest::send_snap_remove() { << "snap_name=" << m_snap_name << ", " << "snap_id=" << m_prev_snap_id << dendl; - auto finish_op_ctx = start_lock_op(); + int r; + auto finish_op_ctx = start_lock_op(&r); if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } @@ -370,10 +372,11 @@ void SnapshotCopyRequest::send_snap_create() { << "snap_id=" << parent_spec.snap_id << ", " << "overlap=" << parent_overlap << "]" << dendl; - Context *finish_op_ctx = start_lock_op(); + int r; + Context *finish_op_ctx = start_lock_op(&r); if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } @@ -477,10 +480,11 @@ void SnapshotCopyRequest::send_snap_protect() { ldout(m_cct, 20) << "snap_name=" << m_snap_name << ", " << "snap_id=" << m_prev_snap_id << dendl; - auto finish_op_ctx = start_lock_op(); + int r; + auto finish_op_ctx = start_lock_op(&r); if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } @@ -571,7 +575,7 @@ void SnapshotCopyRequest::send_resize_object_map() { ldout(m_cct, 20) << dendl; - auto finish_op_ctx = start_lock_op(m_dst_image_ctx->owner_lock); + auto finish_op_ctx = start_lock_op(m_dst_image_ctx->owner_lock, &r); if (finish_op_ctx != nullptr) { auto ctx = new FunctionContext([this, finish_op_ctx](int r) { handle_resize_object_map(r); @@ -584,7 +588,6 @@ void SnapshotCopyRequest::send_resize_object_map() { } lderr(m_cct) << "lost exclusive lock" << dendl; - r = -EROFS; } } @@ -644,18 +647,18 @@ int SnapshotCopyRequest::validate_parent(I *image_ctx, } template -Context *SnapshotCopyRequest::start_lock_op() { +Context *SnapshotCopyRequest::start_lock_op(int* r) { RWLock::RLocker owner_locker(m_dst_image_ctx->owner_lock); - return start_lock_op(m_dst_image_ctx->owner_lock); + return start_lock_op(m_dst_image_ctx->owner_lock, r); } template -Context *SnapshotCopyRequest::start_lock_op(RWLock &owner_lock) { +Context *SnapshotCopyRequest::start_lock_op(RWLock &owner_lock, int* r) { ceph_assert(m_dst_image_ctx->owner_lock.is_locked()); if (m_dst_image_ctx->exclusive_lock == nullptr) { return new FunctionContext([](int r) {}); } - return m_dst_image_ctx->exclusive_lock->start_op(); + return m_dst_image_ctx->exclusive_lock->start_op(r); } template diff --git a/src/librbd/deep_copy/SnapshotCopyRequest.h b/src/librbd/deep_copy/SnapshotCopyRequest.h index 994344227608a..1e4f3badba0ca 100644 --- a/src/librbd/deep_copy/SnapshotCopyRequest.h +++ b/src/librbd/deep_copy/SnapshotCopyRequest.h @@ -126,8 +126,8 @@ private: int validate_parent(ImageCtxT *image_ctx, cls::rbd::ParentImageSpec *spec); - Context *start_lock_op(); - Context *start_lock_op(RWLock &owner_lock); + Context *start_lock_op(int* r); + Context *start_lock_op(RWLock &owner_locki, int* r); void finish(int r); }; diff --git a/src/librbd/deep_copy/SnapshotCreateRequest.cc b/src/librbd/deep_copy/SnapshotCreateRequest.cc index 1a8800cb64658..0ff9c8325fa59 100644 --- a/src/librbd/deep_copy/SnapshotCreateRequest.cc +++ b/src/librbd/deep_copy/SnapshotCreateRequest.cc @@ -68,10 +68,11 @@ template void SnapshotCreateRequest::send_create_snap() { ldout(m_cct, 20) << "snap_name=" << m_snap_name << dendl; - auto finish_op_ctx = start_lock_op(); + int r; + auto finish_op_ctx = start_lock_op(&r); if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } @@ -131,10 +132,11 @@ void SnapshotCreateRequest::send_create_object_map() { librados::ObjectWriteOperation op; librbd::cls_client::object_map_resize(&op, object_count, OBJECT_NONEXISTENT); - auto finish_op_ctx = start_lock_op(); + int r; + auto finish_op_ctx = start_lock_op(&r); if (finish_op_ctx == nullptr) { lderr(m_cct) << "lost exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } @@ -143,7 +145,7 @@ void SnapshotCreateRequest::send_create_object_map() { finish_op_ctx->complete(0); }); librados::AioCompletion *comp = create_rados_callback(ctx); - int r = m_dst_image_ctx->md_ctx.aio_operate(object_map_oid, comp, &op); + r = m_dst_image_ctx->md_ctx.aio_operate(object_map_oid, comp, &op); ceph_assert(r == 0); comp->release(); } @@ -163,12 +165,12 @@ void SnapshotCreateRequest::handle_create_object_map(int r) { } template -Context *SnapshotCreateRequest::start_lock_op() { +Context *SnapshotCreateRequest::start_lock_op(int* r) { RWLock::RLocker owner_locker(m_dst_image_ctx->owner_lock); if (m_dst_image_ctx->exclusive_lock == nullptr) { return new FunctionContext([](int r) {}); } - return m_dst_image_ctx->exclusive_lock->start_op(); + return m_dst_image_ctx->exclusive_lock->start_op(r); } template diff --git a/src/librbd/deep_copy/SnapshotCreateRequest.h b/src/librbd/deep_copy/SnapshotCreateRequest.h index 30a31dc591a38..8c228063a24f3 100644 --- a/src/librbd/deep_copy/SnapshotCreateRequest.h +++ b/src/librbd/deep_copy/SnapshotCreateRequest.h @@ -82,7 +82,7 @@ private: void send_create_object_map(); void handle_create_object_map(int r); - Context *start_lock_op(); + Context *start_lock_op(int* r); void finish(int r); }; diff --git a/src/librbd/image/RemoveRequest.cc b/src/librbd/image/RemoveRequest.cc index f06345ab3c30a..d6edb2c9f5103 100644 --- a/src/librbd/image/RemoveRequest.cc +++ b/src/librbd/image/RemoveRequest.cc @@ -128,7 +128,8 @@ void RemoveRequest::handle_open_image(int r) { template void RemoveRequest::check_exclusive_lock() { if (m_image_ctx->operations_disabled) { - lderr(m_cct) << "image operations disabled due to unsupported op features" << dendl; + lderr(m_cct) << "image operations disabled due to unsupported op features" + << dendl; send_close_image(-EROFS); return; } diff --git a/src/librbd/internal.cc b/src/librbd/internal.cc index 88271739cc2e5..534b80bb5f4c5 100644 --- a/src/librbd/internal.cc +++ b/src/librbd/internal.cc @@ -1177,11 +1177,12 @@ bool compare_by_name(const child_info_t& c1, const child_info_t& c2) int is_exclusive_lock_owner(ImageCtx *ictx, bool *is_owner) { + CephContext *cct = ictx->cct; + ldout(cct, 20) << __func__ << ": ictx=" << ictx << dendl; *is_owner = false; RWLock::RLocker owner_locker(ictx->owner_lock); - if (ictx->exclusive_lock == nullptr || - !ictx->exclusive_lock->is_lock_owner()) { + if (ictx->exclusive_lock == nullptr) { return 0; } @@ -1237,11 +1238,11 @@ bool compare_by_name(const child_info_t& c1, const child_info_t& c2) } RWLock::RLocker l(ictx->owner_lock); - - if (ictx->exclusive_lock == nullptr || - !ictx->exclusive_lock->is_lock_owner()) { + if (ictx->exclusive_lock == nullptr) { + return -EINVAL; + } else if (!ictx->exclusive_lock->is_lock_owner()) { lderr(cct) << "failed to acquire exclusive lock" << dendl; - return -EROFS; + return ictx->exclusive_lock->get_unlocked_op_error(); } return 0; diff --git a/src/librbd/io/ImageRequestWQ.cc b/src/librbd/io/ImageRequestWQ.cc index 80ac6de363c3a..393211a0dca87 100644 --- a/src/librbd/io/ImageRequestWQ.cc +++ b/src/librbd/io/ImageRequestWQ.cc @@ -7,6 +7,7 @@ #include "librbd/ExclusiveLock.h" #include "librbd/ImageCtx.h" #include "librbd/ImageState.h" +#include "librbd/ImageWatcher.h" #include "librbd/internal.h" #include "librbd/Utils.h" #include "librbd/exclusive_lock/Policy.h" @@ -725,7 +726,8 @@ void *ImageRequestWQ::_void_dequeue() { ldout(cct, 5) << "exclusive lock required: delaying IO " << item << dendl; if (!m_image_ctx.get_exclusive_lock_policy()->may_auto_request_lock()) { lderr(cct) << "op requires exclusive lock" << dendl; - fail_in_flight_io(-EROFS, item); + fail_in_flight_io(m_image_ctx.exclusive_lock->get_unlocked_op_error(), + item); // wake up the IO since we won't be returning a request to process this->signal(); diff --git a/src/librbd/mirror/DemoteRequest.cc b/src/librbd/mirror/DemoteRequest.cc index 1fb23a5ddf225..c5d38752ea920 100644 --- a/src/librbd/mirror/DemoteRequest.cc +++ b/src/librbd/mirror/DemoteRequest.cc @@ -105,11 +105,12 @@ void DemoteRequest::handle_acquire_lock(int r) { } m_image_ctx.owner_lock.get_read(); - if (m_image_ctx.exclusive_lock == nullptr || + if (m_image_ctx.exclusive_lock != nullptr && !m_image_ctx.exclusive_lock->is_lock_owner()) { + r = m_image_ctx.exclusive_lock->get_unlocked_op_error(); m_image_ctx.owner_lock.put_read(); lderr(cct) << "failed to acquire exclusive lock" << dendl; - finish(-EROFS); + finish(r); return; } m_image_ctx.owner_lock.put_read(); diff --git a/src/librbd/operation/DisableFeaturesRequest.cc b/src/librbd/operation/DisableFeaturesRequest.cc index afb99e34b929d..a248ec7c427f5 100644 --- a/src/librbd/operation/DisableFeaturesRequest.cc +++ b/src/librbd/operation/DisableFeaturesRequest.cc @@ -160,19 +160,20 @@ Context *DisableFeaturesRequest::handle_acquire_exclusive_lock(int *result) { CephContext *cct = image_ctx.cct; ldout(cct, 20) << this << " " << __func__ << ": r=" << *result << dendl; + image_ctx.owner_lock.get_read(); if (*result < 0) { lderr(cct) << "failed to lock image: " << cpp_strerror(*result) << dendl; + image_ctx.owner_lock.put_read(); return handle_finish(*result); - } else if (m_acquired_lock && (image_ctx.exclusive_lock == nullptr || - !image_ctx.exclusive_lock->is_lock_owner())) { + } else if (image_ctx.exclusive_lock != nullptr && + !image_ctx.exclusive_lock->is_lock_owner()) { lderr(cct) << "failed to acquire exclusive lock" << dendl; - *result = -EROFS; + *result = image_ctx.exclusive_lock->get_unlocked_op_error(); + image_ctx.owner_lock.put_read(); return handle_finish(*result); } do { - RWLock::WLocker locker(image_ctx.owner_lock); - m_features &= image_ctx.features; m_new_features = image_ctx.features & ~m_features; m_features_mask = m_features; @@ -196,6 +197,7 @@ Context *DisableFeaturesRequest::handle_acquire_exclusive_lock(int *result) { m_disable_flags |= RBD_FLAG_OBJECT_MAP_INVALID; } } while (false); + image_ctx.owner_lock.put_read(); if (*result < 0) { return handle_finish(*result); diff --git a/src/test/librbd/deep_copy/test_mock_ObjectCopyRequest.cc b/src/test/librbd/deep_copy/test_mock_ObjectCopyRequest.cc index bc0f4a6b17bd4..aefac1279dddb 100644 --- a/src/test/librbd/deep_copy/test_mock_ObjectCopyRequest.cc +++ b/src/test/librbd/deep_copy/test_mock_ObjectCopyRequest.cc @@ -167,7 +167,7 @@ public: if ((m_src_image_ctx->features & RBD_FEATURE_EXCLUSIVE_LOCK) == 0) { return; } - EXPECT_CALL(mock_exclusive_lock, start_op()).WillOnce( + EXPECT_CALL(mock_exclusive_lock, start_op(_)).WillOnce( ReturnNew([](int) {})); } diff --git a/src/test/librbd/deep_copy/test_mock_SetHeadRequest.cc b/src/test/librbd/deep_copy/test_mock_SetHeadRequest.cc index 42bf0baa3c9b6..e417374049e37 100644 --- a/src/test/librbd/deep_copy/test_mock_SetHeadRequest.cc +++ b/src/test/librbd/deep_copy/test_mock_SetHeadRequest.cc @@ -110,7 +110,7 @@ public: } void expect_start_op(librbd::MockExclusiveLock &mock_exclusive_lock) { - EXPECT_CALL(mock_exclusive_lock, start_op()).WillOnce( + EXPECT_CALL(mock_exclusive_lock, start_op(_)).WillOnce( ReturnNew([](int) {})); } diff --git a/src/test/librbd/deep_copy/test_mock_SnapshotCopyRequest.cc b/src/test/librbd/deep_copy/test_mock_SnapshotCopyRequest.cc index 44eb4b2bb516f..2e15b4d4d85e7 100644 --- a/src/test/librbd/deep_copy/test_mock_SnapshotCopyRequest.cc +++ b/src/test/librbd/deep_copy/test_mock_SnapshotCopyRequest.cc @@ -148,7 +148,7 @@ public: if ((m_src_image_ctx->features & RBD_FEATURE_EXCLUSIVE_LOCK) == 0) { return; } - EXPECT_CALL(mock_exclusive_lock, start_op()).WillOnce( + EXPECT_CALL(mock_exclusive_lock, start_op(_)).WillOnce( ReturnNew([](int) {})); } diff --git a/src/test/librbd/deep_copy/test_mock_SnapshotCreateRequest.cc b/src/test/librbd/deep_copy/test_mock_SnapshotCreateRequest.cc index 64d2d11d710bf..57945e70cf2da 100644 --- a/src/test/librbd/deep_copy/test_mock_SnapshotCreateRequest.cc +++ b/src/test/librbd/deep_copy/test_mock_SnapshotCreateRequest.cc @@ -89,7 +89,7 @@ public: } void expect_start_op(librbd::MockExclusiveLock &mock_exclusive_lock) { - EXPECT_CALL(mock_exclusive_lock, start_op()).WillOnce( + EXPECT_CALL(mock_exclusive_lock, start_op(_)).WillOnce( ReturnNew([](int) {})); } diff --git a/src/test/librbd/io/test_mock_ImageRequestWQ.cc b/src/test/librbd/io/test_mock_ImageRequestWQ.cc index b3c0042fc253a..b15209608642a 100644 --- a/src/test/librbd/io/test_mock_ImageRequestWQ.cc +++ b/src/test/librbd/io/test_mock_ImageRequestWQ.cc @@ -296,6 +296,50 @@ TEST_F(TestMockIoImageRequestWQ, AcquireLockError) { aio_comp->release(); } +TEST_F(TestMockIoImageRequestWQ, AcquireLockBlacklisted) { + REQUIRE_FEATURE(RBD_FEATURE_EXCLUSIVE_LOCK); + + librbd::ImageCtx *ictx; + ASSERT_EQ(0, open_image(m_image_name, &ictx)); + + MockTestImageCtx mock_image_ctx(*ictx); + MockExclusiveLock mock_exclusive_lock; + mock_image_ctx.exclusive_lock = &mock_exclusive_lock; + + auto mock_queued_image_request = new MockImageDispatchSpec(); + expect_was_throttled(*mock_queued_image_request, false); + expect_set_throttled(*mock_queued_image_request); + + InSequence seq; + MockImageRequestWQ mock_image_request_wq(&mock_image_ctx, "io", 60, nullptr); + expect_signal(mock_image_request_wq); + mock_image_request_wq.set_require_lock(DIRECTION_WRITE, true); + + expect_is_write_op(*mock_queued_image_request, true); + expect_queue(mock_image_request_wq); + auto *aio_comp = new librbd::io::AioCompletion(); + mock_image_request_wq.aio_write(aio_comp, 0, 0, {}, 0); + + librbd::exclusive_lock::MockPolicy mock_exclusive_lock_policy; + expect_front(mock_image_request_wq, mock_queued_image_request); + expect_is_refresh_request(mock_image_ctx, false); + expect_is_write_op(*mock_queued_image_request, true); + expect_dequeue(mock_image_request_wq, mock_queued_image_request); + expect_get_exclusive_lock_policy(mock_image_ctx, mock_exclusive_lock_policy); + expect_may_auto_request_lock(mock_exclusive_lock_policy, false); + EXPECT_CALL(*mock_image_ctx.exclusive_lock, get_unlocked_op_error()) + .WillOnce(Return(-EBLACKLISTED)); + expect_process_finish(mock_image_request_wq); + expect_fail(*mock_queued_image_request, -EBLACKLISTED); + expect_is_write_op(*mock_queued_image_request, true); + expect_signal(mock_image_request_wq); + ASSERT_TRUE(mock_image_request_wq.invoke_dequeue() == nullptr); + + ASSERT_EQ(0, aio_comp->wait_for_complete()); + ASSERT_EQ(-EBLACKLISTED, aio_comp->get_return_value()); + aio_comp->release(); +} + TEST_F(TestMockIoImageRequestWQ, RefreshError) { librbd::ImageCtx *ictx; ASSERT_EQ(0, open_image(m_image_name, &ictx)); diff --git a/src/test/librbd/mock/MockExclusiveLock.h b/src/test/librbd/mock/MockExclusiveLock.h index f8eeb0d20a850..1b49fa6a75dc1 100644 --- a/src/test/librbd/mock/MockExclusiveLock.h +++ b/src/test/librbd/mock/MockExclusiveLock.h @@ -31,7 +31,7 @@ struct MockExclusiveLock { MOCK_METHOD0(accept_ops, bool()); MOCK_METHOD0(get_unlocked_op_error, int()); - MOCK_METHOD0(start_op, Context*()); + MOCK_METHOD1(start_op, Context*(int*)); }; } // namespace librbd diff --git a/src/test/librbd/test_mock_DeepCopyRequest.cc b/src/test/librbd/test_mock_DeepCopyRequest.cc index 31de7c67aea4e..fd45e9f0e5d4f 100644 --- a/src/test/librbd/test_mock_DeepCopyRequest.cc +++ b/src/test/librbd/test_mock_DeepCopyRequest.cc @@ -170,7 +170,7 @@ public: } void expect_start_op(librbd::MockExclusiveLock &mock_exclusive_lock) { - EXPECT_CALL(mock_exclusive_lock, start_op()).WillOnce( + EXPECT_CALL(mock_exclusive_lock, start_op(_)).WillOnce( ReturnNew([](int) {})); } diff --git a/src/test/rbd_mirror/image_deleter/test_mock_SnapshotPurgeRequest.cc b/src/test/rbd_mirror/image_deleter/test_mock_SnapshotPurgeRequest.cc index daff8b33e3f2d..35850d3a39aab 100644 --- a/src/test/rbd_mirror/image_deleter/test_mock_SnapshotPurgeRequest.cc +++ b/src/test/rbd_mirror/image_deleter/test_mock_SnapshotPurgeRequest.cc @@ -139,9 +139,10 @@ public: } void expect_start_op(librbd::MockTestImageCtx &mock_image_ctx, bool success) { - EXPECT_CALL(*mock_image_ctx.exclusive_lock, start_op()) - .WillOnce(Invoke([success]() { + EXPECT_CALL(*mock_image_ctx.exclusive_lock, start_op(_)) + .WillOnce(Invoke([success](int* r) { if (!success) { + *r = -EROFS; return static_cast(nullptr); } return new FunctionContext([](int r) {}); diff --git a/src/tools/rbd_mirror/image_deleter/SnapshotPurgeRequest.cc b/src/tools/rbd_mirror/image_deleter/SnapshotPurgeRequest.cc index 4d1c3737d61a4..a0e9fd908976d 100644 --- a/src/tools/rbd_mirror/image_deleter/SnapshotPurgeRequest.cc +++ b/src/tools/rbd_mirror/image_deleter/SnapshotPurgeRequest.cc @@ -151,10 +151,10 @@ void SnapshotPurgeRequest::snap_unprotect() { << "snap_namespace=" << m_snap_namespace << ", " << "snap_name=" << m_snap_name << dendl; - auto finish_op_ctx = start_lock_op(); + auto finish_op_ctx = start_lock_op(&r); if (finish_op_ctx == nullptr) { derr << "lost exclusive lock" << dendl; - m_ret_val = -EROFS; + m_ret_val = r; close_image(); return; } @@ -205,10 +205,11 @@ void SnapshotPurgeRequest::snap_remove() { << "snap_namespace=" << m_snap_namespace << ", " << "snap_name=" << m_snap_name << dendl; - auto finish_op_ctx = start_lock_op(); + int r; + auto finish_op_ctx = start_lock_op(&r); if (finish_op_ctx == nullptr) { derr << "lost exclusive lock" << dendl; - m_ret_val = -EROFS; + m_ret_val = r; close_image(); return; } @@ -277,9 +278,9 @@ void SnapshotPurgeRequest::finish(int r) { } template -Context *SnapshotPurgeRequest::start_lock_op() { +Context *SnapshotPurgeRequest::start_lock_op(int* r) { RWLock::RLocker owner_locker(m_image_ctx->owner_lock); - return m_image_ctx->exclusive_lock->start_op(); + return m_image_ctx->exclusive_lock->start_op(r); } } // namespace image_deleter diff --git a/src/tools/rbd_mirror/image_deleter/SnapshotPurgeRequest.h b/src/tools/rbd_mirror/image_deleter/SnapshotPurgeRequest.h index 59a13cb8f4482..b8b635fe765ae 100644 --- a/src/tools/rbd_mirror/image_deleter/SnapshotPurgeRequest.h +++ b/src/tools/rbd_mirror/image_deleter/SnapshotPurgeRequest.h @@ -90,7 +90,7 @@ private: void finish(int r); - Context *start_lock_op(); + Context *start_lock_op(int* r); };