From: Loic Dachary <loic-201408@dachary.org>
Date: Tue, 16 Sep 2014 18:29:12 +0000 (+0200)
Subject: crushtool: safeguard for missing --num-rep when --test
X-Git-Tag: v0.86~64^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F2508%2Fhead;p=ceph.git

crushtool: safeguard for missing --num-rep when --test

http://tracker.ceph.com/issues/9490 Fixes: #9490

Signed-off-by: Loic Dachary <loic-201408@dachary.org>
---

diff --git a/src/tools/crushtool.cc b/src/tools/crushtool.cc
index ccb0efda74a7..10adc11a4954 100644
--- a/src/tools/crushtool.cc
+++ b/src/tools/crushtool.cc
@@ -729,6 +729,10 @@ int main(int argc, const char **argv)
   }
 
   if (test) {
+    if (tester.get_min_rep() < 1 || tester.get_max_rep() < 1) {
+      cerr << me << " --test requires --num-rep with a value > 0 " << std::endl;
+      exit(1);
+    }
     if (tester.get_output_utilization_all() ||
 	tester.get_output_utilization())
       tester.set_output_statistics(true);