From: ningtao <ningtao@sangfor.com.cn>
Date: Thu, 3 Jan 2019 15:20:12 +0000 (+0800)
Subject: mon: shutdown messenger early to avoid accessing deleted logger
X-Git-Tag: v14.1.0~494^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F25760%2Fhead;p=ceph.git

mon: shutdown messenger early to avoid accessing deleted logger

In the monitor shutdown process, the MSG thread exits after the logger is released,
causing the null pointer to be accessed. So move the logger release to the MSG thread after it exits

Fixes: http://tracker.ceph.com/issues/37780

Signed-off-by: ningtao <ningtao@sangfor.com.cn>
---

diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc
index 2dc44ac82953..6c43817b1556 100644
--- a/src/mon/Monitor.cc
+++ b/src/mon/Monitor.cc
@@ -986,6 +986,16 @@ void Monitor::shutdown()
 
   remove_all_sessions();
 
+  log_client.shutdown();
+
+  // unlock before msgr shutdown...
+  lock.Unlock();
+
+  // shutdown messenger before removing logger from perfcounter collection, 
+  // otherwise _ms_dispatch() will try to update deleted logger
+  messenger->shutdown();
+  mgr_messenger->shutdown();
+
   if (logger) {
     cct->get_perfcounters_collection()->remove(logger);
     delete logger;
@@ -997,14 +1007,6 @@ void Monitor::shutdown()
     delete cluster_logger;
     cluster_logger = NULL;
   }
-
-  log_client.shutdown();
-
-  // unlock before msgr shutdown...
-  lock.Unlock();
-
-  messenger->shutdown();  // last thing!  ceph_mon.cc will delete mon.
-  mgr_messenger->shutdown();
 }
 
 void Monitor::wait_for_paxos_write()