From: Kefu Chai <kchai@redhat.com>
Date: Mon, 11 Mar 2019 11:08:03 +0000 (+0800)
Subject: osd/osd_types: remove copy ctor of osd_reqid_t
X-Git-Tag: v15.0.0~189^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F27003%2Fhead;p=ceph.git

osd/osd_types: remove copy ctor of osd_reqid_t

do not define the copy constructor of osd_reqid_t explicitly. compiler
will define a default one for us. the implicitly defined one will call
the copy constructor of each member variable. so it is as good as the
user-defined one.

another reason to remove this copy ctor is that, it prevents the
compiler from defining a default move constructor, without which, we
cannot return `future<object_info_t>`. as `object_info_t` contains an
instance of `osd_reqid_t`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/osd/osd_types.h b/src/osd/osd_types.h
index 8dea9c96271..a4b7b08f651 100644
--- a/src/osd/osd_types.h
+++ b/src/osd/osd_types.h
@@ -133,9 +133,6 @@ struct osd_reqid_t {
   osd_reqid_t()
     : tid(0), inc(0)
   {}
-  osd_reqid_t(const osd_reqid_t& other)
-    : name(other.name), tid(other.tid), inc(other.inc)
-  {}
   osd_reqid_t(const entity_name_t& a, int i, ceph_tid_t t)
     : name(a), tid(t), inc(i)
   {}