From: Zengran Zhang <zhangzengran@sangfor.com.cn>
Date: Wed, 27 Mar 2019 01:39:31 +0000 (+0800)
Subject: osd: shutdown recovery_request_timer earlier
X-Git-Tag: v15.0.0~31^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F27206%2Fhead;p=ceph.git

osd: shutdown recovery_request_timer earlier

recovery_request_timer may hold some QueuePeeringEvts which PGRef,
if we dont shutdown it earlier, it potentially cause the PGRef leak
when kicking pg.

Fixes: https://tracker.ceph.com/issues/38945

Signed-off-by: Zengran Zhang <zhangzengran@sangfor.com.cn>
---

diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc
index 020fb437294..ded6e8c3baa 100644
--- a/src/osd/OSD.cc
+++ b/src/osd/OSD.cc
@@ -443,6 +443,11 @@ void OSDService::start_shutdown()
     std::lock_guard l(sleep_lock);
     sleep_timer.shutdown();
   }
+
+  {
+    std::lock_guard l(recovery_request_lock);
+    recovery_request_timer.shutdown();
+  }
 }
 
 void OSDService::shutdown_reserver()
@@ -464,11 +469,6 @@ void OSDService::shutdown()
     f->stop();
   }
 
-  {
-    std::lock_guard l(recovery_request_lock);
-    recovery_request_timer.shutdown();
-  }
-
   osdmap = OSDMapRef();
   next_osdmap = OSDMapRef();
 }