From: Alfredo Deza <adeza@redhat.com>
Date: Tue, 12 Jan 2016 12:45:23 +0000 (-0500)
Subject: be more verbose when a commit fails
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F290%2Fhead;p=ceph-build.git

be more verbose when a commit fails

Signed-off-by: Alfredo Deza <adeza@redhat.com>
---

diff --git a/ceph-pr-commits/build/test_commits.py b/ceph-pr-commits/build/test_commits.py
index 2ce809c9..6292bbf1 100644
--- a/ceph-pr-commits/build/test_commits.py
+++ b/ceph-pr-commits/build/test_commits.py
@@ -14,6 +14,7 @@ ceph_checkout = os.path.join(workspace, 'ceph')
 
 
 def run(command):
+    print "Running command: %s" % ' '.join(command)
     process = Popen(
         command,
         cwd=ceph_checkout,
@@ -45,7 +46,14 @@ class TestSignedOffByCommits(object):
 
     def test_signed_off_by(self):
         for commit in get_commits():
-            assert 'Signed-off-by:' in commit
+            if 'Signed-off-by:' not in commit:
+                msg = (
+                    "\nFollowing commit is not signed, please make sure all commits",
+                    "\nare signed following the 'Submitting Patches' guide:",
+                    "\nhttps://github.com/ceph/ceph/blob/master/SubmittingPatches#L61",
+                    "\n",
+                    commit)
+                raise AssertionError, ' '.join(msg)
 
     def extract_sha(self, lines):
         # XXX Unused for now, if py.test can spit out the hashes in verbose