From: Patrick Seidensal <pseidensal@suse.com>
Date: Fri, 13 Sep 2019 15:02:18 +0000 (+0200)
Subject: mgr/dashboard: Firefox ngx-datatable performance issue
X-Git-Tag: v15.1.0~1527^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F30316%2Fhead;p=ceph.git

mgr/dashboard: Firefox ngx-datatable performance issue

Fixes: https://tracker.ceph.com/issues/41667

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
---

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.spec.ts
index 0e5fd417a4f1..3d5a8101f9f8 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.spec.ts
@@ -92,7 +92,7 @@ describe('TableComponent', () => {
     mouseEvent.stopPropagation = () => {
       wasCalled = true;
     };
-    spyOn(window, 'addEventListener').and.callFake((eventName, fn) => {
+    spyOn(component.table.element, 'addEventListener').and.callFake((eventName, fn) => {
       fn(mouseEvent);
       expect(eventName).toBe('mouseenter');
       expect(wasCalled).toBe(true);
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts
index 1d025c6a6ef9..d03bee3889a7 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts
@@ -179,7 +179,7 @@ export class TableComponent implements AfterContentChecked, OnInit, OnChanges, O
   ngOnInit() {
     // ngx-datatable triggers calculations each time mouse enters a row,
     // this will prevent that.
-    window.addEventListener('mouseenter', (event) => event.stopPropagation(), true);
+    this.table.element.addEventListener('mouseenter', (e) => e.stopPropagation(), true);
     this._addTemplates();
     if (!this.sorts) {
       // Check whether the specified identifier exists.