From: Sage Weil <sage@redhat.com>
Date: Mon, 23 Dec 2019 16:29:52 +0000 (-0600)
Subject: mgr/cephadm: fix =[] default arg to _create_daemon
X-Git-Tag: v15.1.0~392^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F32281%2Fhead;p=ceph.git

mgr/cephadm: fix =[] default arg to _create_daemon

This is a no-no (pass by reference, not value)!

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py
index 89e04bc2ec6..384fba9e767 100644
--- a/src/pybind/mgr/cephadm/module.py
+++ b/src/pybind/mgr/cephadm/module.py
@@ -1044,8 +1044,10 @@ class CephadmOrchestrator(MgrModule, orchestrator.Orchestrator):
         return self._remove_daemon(args)
 
     def _create_daemon(self, daemon_type, daemon_id, host, keyring,
-                       extra_args=[], extra_config=None,
+                       extra_args=None, extra_config=None,
                        reconfig=False):
+        if not extra_args:
+            extra_args = []
         name = '%s.%s' % (daemon_type, daemon_id)
 
         # generate config