From: Yan, Zheng <zyan@redhat.com>
Date: Tue, 6 Jan 2015 12:17:28 +0000 (+0800)
Subject: client: fix use-after-free bug in unmount()
X-Git-Tag: v0.92~68^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F3300%2Fhead;p=ceph.git

client: fix use-after-free bug in unmount()

If there is error, _release_fh() already outputs error message.
No need to print extra error message

Fixes: #10412
Signed-off-by: Yan, Zheng <zyan@redhat.com>
---

diff --git a/src/client/Client.cc b/src/client/Client.cc
index 599673d9fbe..9cbd1cf12ad 100644
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -4637,9 +4637,8 @@ void Client::unmount()
   while (!fd_map.empty()) {
     Fh *fh = fd_map.begin()->second;
     fd_map.erase(fd_map.begin());
-    int release_err = _release_fh(fh);
-    ldout(cct, 0) << " destroyed lost open file " << fh << " on " << *fh->inode << "(async_err = " << release_err << ")" << dendl;
-
+    ldout(cct, 0) << " destroyed lost open file " << fh << " on " << *fh->inode << dendl;
+    _release_fh(fh);
   }
 
   _ll_drop_pins();