From: Ramana Raja Date: Tue, 11 Feb 2020 10:49:09 +0000 (-0500) Subject: mgr/volumes: fix py2 compat issue X-Git-Tag: v14.2.8~49^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F33122%2Fhead;p=ceph.git mgr/volumes: fix py2 compat issue Fix the following issue seen while upstream teuthology testing, File "/usr/share/ceph/mgr/volumes/fs/operations/versions/subvolume_base.py", line 98, in load_config self.metadata_mgr = MetadataManager(self.fs, self.legacy_config_path, 0o640) File "/usr/share/ceph/mgr/volumes/fs/operations/versions/subvolume_base.py", line 73, in legacy_config_path meta_config = "{0}.meta".format(m.digest().hex()) AttributeError: 'str' object has no attribute 'hex' This issue is not observed in master/octopus, as it only supports py3. Signed-off-by: Ramana Raja --- diff --git a/src/pybind/mgr/volumes/fs/operations/versions/subvolume_base.py b/src/pybind/mgr/volumes/fs/operations/versions/subvolume_base.py index 466db0f6eb9a..7a3c9ee36030 100644 --- a/src/pybind/mgr/volumes/fs/operations/versions/subvolume_base.py +++ b/src/pybind/mgr/volumes/fs/operations/versions/subvolume_base.py @@ -70,7 +70,7 @@ class SubvolumeBase(object): def legacy_config_path(self): m = md5() m.update(self.base_path) - meta_config = "{0}.meta".format(m.digest().hex()) + meta_config = "{0}.meta".format(m.hexdigest()) return os.path.join(self.legacy_dir, meta_config.encode('utf-8')) @property