From: Kefu Chai Date: Tue, 3 Mar 2020 16:24:08 +0000 (+0800) Subject: qa/tasks/test_orchestrator_cli: enable test_osd_create exception check X-Git-Tag: v15.1.1~132^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F33701%2Fhead;p=ceph.git qa/tasks/test_orchestrator_cli: enable test_osd_create exception check this reverts 9639acfefe09c87adc821bb5c5cc41974685331d, as the test does make sense. what fails this test is the machinary to marshal/unmarshal exception fails to handle un-picklable exceptions. the previous commit is supposed to use a fallback to handle them. Signed-off-by: Kefu Chai --- diff --git a/qa/tasks/mgr/test_orchestrator_cli.py b/qa/tasks/mgr/test_orchestrator_cli.py index c4e2bdc5bc1c..94d87299815e 100644 --- a/qa/tasks/mgr/test_orchestrator_cli.py +++ b/qa/tasks/mgr/test_orchestrator_cli.py @@ -95,8 +95,8 @@ class TestOrchestratorCli(MgrTestCase): res = self._orch_cmd_result("osd", "create", "-i", "-", stdin=json.dumps(drive_groups)) self.assertEqual(res, 0) - #with self.assertRaises(Exception): - # self._orch_cmd("osd", "create", "notfound:device") + with self.assertRaises(Exception): + self._orch_cmd("osd", "create", "notfound:device") def test_blink_device_light(self): def _ls_lights(what):