From: lijiaxu Date: Thu, 16 Apr 2020 08:36:14 +0000 (+0800) Subject: qa/workunits/erasure-code/bench.sh:fix the error of getting encoding technique in... X-Git-Tag: v16.1.0~2277^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F34593%2Fhead;p=ceph.git qa/workunits/erasure-code/bench.sh:fix the error of getting encoding technique in ec test Isa / jerasure codec ‘technique’, obtained by the following statements, "eval technique_parameter=\$${plugin}2technique_${technique}", which generate a string such as "isa2technique_vandermonde", and assign the value of "technique_parameter" to "isa2technique_vandermonde". String such as "isa2technique_vandermonde" should have a preset value, but it does not, which will cause string "technique_parameter" to be empty. Run the script, prompt the following error message and exit: isa technique= is not a valid coding technique. Choose one of the following: reed_sol_van,cauchy To fix the bug, specify a preset value for "technique_parameter": + isa2technique_vandermonde='reed_sol_van' + isa2technique_cauchy='cauchy' + jerasure2technique_vandermonde='reed_sol_van' + jerasure2technique_cauchy='cauchy_good' Signed-off-by: lijiaxu --- diff --git a/qa/workunits/erasure-code/bench.sh b/qa/workunits/erasure-code/bench.sh index 23914ef82d2e..8e288f053eca 100755 --- a/qa/workunits/erasure-code/bench.sh +++ b/qa/workunits/erasure-code/bench.sh @@ -111,6 +111,10 @@ function bench_run() { k2ms[4]="2 3" k2ms[6]="2 3 4" k2ms[10]="3 4" + local isa2technique_vandermonde='reed_sol_van' + local isa2technique_cauchy='cauchy' + local jerasure2technique_vandermonde='reed_sol_van' + local jerasure2technique_cauchy='cauchy_good' for technique in ${TECHNIQUES} ; do for plugin in ${PLUGINS} ; do eval technique_parameter=\$${plugin}2technique_${technique}