From: Yuan Zhou Date: Fri, 30 Jan 2015 03:43:19 +0000 (+0800) Subject: rgw: Response 204 when post on containers X-Git-Tag: v0.93~154^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F3546%2Fhead;p=ceph.git rgw: Response 204 when post on containers Currently POST request on container returns 202 if success. But in Swift the code is 204. Let's use 204 to keep align with the Swift API. Fixes #10667 Signed-off-by: Yuan Zhou --- diff --git a/src/rgw/rgw_rest_swift.cc b/src/rgw/rgw_rest_swift.cc index f3852b9a8428..bf869738330d 100644 --- a/src/rgw/rgw_rest_swift.cc +++ b/src/rgw/rgw_rest_swift.cc @@ -449,8 +449,13 @@ int RGWPutMetadata_ObjStore_SWIFT::get_params() void RGWPutMetadata_ObjStore_SWIFT::send_response() { - if (!ret) - ret = STATUS_ACCEPTED; + if (!ret) { + /* Return 204 when post metadata on a container */ + if (s->object.empty()) + ret = STATUS_NO_CONTENT; + else + ret = STATUS_ACCEPTED; + } set_req_state_err(s, ret); dump_errno(s); end_header(s, this);