From: Volker Theile Date: Fri, 3 Jul 2020 14:09:42 +0000 (+0200) Subject: mgr/dashboard: Fix bugs in a unit test and i18n translation X-Git-Tag: v16.1.0~1819^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F35923%2Fhead;p=ceph.git mgr/dashboard: Fix bugs in a unit test and i18n translation * SKIP: Unknown argument type: 'BinaryExpression' NodeObject { ... text: 'You can activate the module on the Telemetry configuration ' * WARNING: /ceph/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.spec.ts:39:32 - get is deprecated: from v9.0.0 use TestBed.inject Fixes: https://tracker.ceph.com/issues/46371 Signed-off-by: Volker Theile --- diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.spec.ts index 51bb131eb843..b3ea48a09351 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.spec.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.spec.ts @@ -36,7 +36,7 @@ describe('RgwBucketListComponent', () => { }); beforeEach(() => { - rgwBucketService = TestBed.get(RgwBucketService); + rgwBucketService = TestBed.inject(RgwBucketService); rgwBucketServiceListSpy = spyOn(rgwBucketService, 'list'); rgwBucketServiceListSpy.and.returnValue(of(null)); fixture = TestBed.createComponent(RgwBucketListComponent); diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.ts index 974f625e1c6a..4b881e2f8e0b 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.ts @@ -61,8 +61,7 @@ export class TelemetryNotificationComponent implements OnInit, OnDestroy { NotificationType.success, this.i18n('Telemetry activation reminder muted'), this.i18n( - 'You can activate the module on the Telemetry configuration ' + - 'page (Dashboard Settings -> Telemetry configuration) at any time.' + 'You can activate the module on the Telemetry configuration page (Dashboard Settings -> Telemetry configuration) at any time.' ) ); }