From: Neha Ojha Date: Fri, 17 Jul 2020 16:52:56 +0000 (+0000) Subject: osd/OSD.cc: remove osd_lock for bench X-Git-Tag: v16.1.0~1639^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F36251%2Fhead;p=ceph.git osd/OSD.cc: remove osd_lock for bench 8987f94416f453829eae6dda08837ef5a42531c6 introduced the osd_lock for the bench command. Taking the osd_lock in bench can lead to deadlocks, causing the command to hang as seen in https://tracker.ceph.com/issues/43888. Fixes: https://tracker.ceph.com/issues/43888 Signed-off-by: Adam Kupczyk Signed-off-by: Neha Ojha --- diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc index ef1583a8ff4e..2c4ea30358ef 100644 --- a/src/osd/OSD.cc +++ b/src/osd/OSD.cc @@ -2731,7 +2731,6 @@ will start to track new ops received afterwards."; } else if (prefix == "bench") { - lock_guard l(osd_lock); int64_t count; int64_t bsize; int64_t osize, onum;