From: Kefu Chai <kchai@redhat.com>
Date: Tue, 4 Aug 2020 07:28:00 +0000 (+0800)
Subject: crimson/admin: do not validate params of ConfigSetHook
X-Git-Tag: v16.1.0~1524^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F36443%2Fhead;p=ceph.git

crimson/admin: do not validate params of ConfigSetHook

validate_cmd() should have taken care of this

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/crimson/admin/admin_socket.cc b/src/crimson/admin/admin_socket.cc
index 5c3da6fa5d17..6d0011489df0 100644
--- a/src/crimson/admin/admin_socket.cc
+++ b/src/crimson/admin/admin_socket.cc
@@ -488,11 +488,8 @@ public:
   {
     std::string var;
     std::vector<std::string> new_val;
-    if (!cmd_getval(cmdmap, "var", var) ||
-        !cmd_getval(cmdmap, "val", new_val)) {
-      return seastar::make_ready_future<tell_result_t>(
-        tell_result_t{-EINVAL, "syntax error: 'config set <var> <value>'"});
-    }
+    cmd_getval(cmdmap, "var", var);
+    cmd_getval(cmdmap, "val", new_val);
     // val may be multiple words
     const std::string joined_values = boost::algorithm::join(new_val, " ");
     return local_conf().set_val(var, joined_values).then([format] {