From: Sebastian Wagner <sebastian.wagner@suse.com>
Date: Fri, 7 Aug 2020 09:24:52 +0000 (+0200)
Subject: mgr/cephadm: _get_config_and_keyring: `host` is required now
X-Git-Tag: v16.1.0~1484^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F36497%2Fhead;p=ceph.git

mgr/cephadm: _get_config_and_keyring: `host` is required now

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
---

diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py
index 8ad4a285117e..11bf92d38aea 100644
--- a/src/pybind/mgr/cephadm/module.py
+++ b/src/pybind/mgr/cephadm/module.py
@@ -1815,10 +1815,10 @@ you may want to run:
                 deps.append(dd.name())
         return sorted(deps)
 
-    def _get_config_and_keyring(self, daemon_type, daemon_id, host=None,
+    def _get_config_and_keyring(self, daemon_type, daemon_id, host,
                                 keyring=None,
                                 extra_ceph_config=None):
-        # type: (str, str, Optional[str], Optional[str], Optional[str]) -> Dict[str, Any]
+        # type: (str, str, str, Optional[str], Optional[str]) -> Dict[str, Any]
         # keyring
         if not keyring:
             ename = utils.name_to_auth_entity(daemon_type, daemon_id, host=host)
diff --git a/src/pybind/mgr/cephadm/services/cephadmservice.py b/src/pybind/mgr/cephadm/services/cephadmservice.py
index 4af2c7e35ec1..e513e809f96c 100644
--- a/src/pybind/mgr/cephadm/services/cephadmservice.py
+++ b/src/pybind/mgr/cephadm/services/cephadmservice.py
@@ -20,7 +20,7 @@ ServiceSpecs = TypeVar('ServiceSpecs', bound=ServiceSpec)
 
 class CephadmDaemonSpec(Generic[ServiceSpecs]):
     # typing.NamedTuple + Generic is broken in py36
-    def __init__(self, host, daemon_id,
+    def __init__(self, host: str, daemon_id,
                  spec: Optional[ServiceSpecs]=None,
                  network: Optional[str]=None,
                  keyring: Optional[str]=None,
@@ -34,7 +34,7 @@ class CephadmDaemonSpec(Generic[ServiceSpecs]):
 
         Would be great to have a consistent usage where all properties are set.
         """
-        self.host = host
+        self.host: str = host
         self.daemon_id = daemon_id
         daemon_type = daemon_type or (spec.service_type if spec else None)
         assert daemon_type is not None
diff --git a/src/pybind/mgr/cephadm/services/nfs.py b/src/pybind/mgr/cephadm/services/nfs.py
index 354529885600..33ce52e946bc 100644
--- a/src/pybind/mgr/cephadm/services/nfs.py
+++ b/src/pybind/mgr/cephadm/services/nfs.py
@@ -64,7 +64,10 @@ class NFSService(CephadmService):
         cephadm_config.update(
             self.mgr._get_config_and_keyring(
                 daemon_type, daemon_id,
-                keyring=keyring))
+                keyring=keyring,
+                host=host
+            )
+        )
 
         return cephadm_config, deps