From: Kefu Chai <kchai@redhat.com>
Date: Sat, 3 Oct 2020 11:05:15 +0000 (+0800)
Subject: crimson/osd: mark Operation::dump_detail() private
X-Git-Tag: v17.0.0~951^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F37532%2Fhead;p=ceph.git

crimson/osd: mark Operation::dump_detail() private

Operation::dump_detail() is called by Operation::dump(), the latter is a
member of Blocker. so there is no need to mark dump_detail() protected
or public to grant the access Operation::dump() the access to this method.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/crimson/osd/osd_operation.h b/src/crimson/osd/osd_operation.h
index 2a2250e6571a5..0641a7bfc43fd 100644
--- a/src/crimson/osd/osd_operation.h
+++ b/src/crimson/osd/osd_operation.h
@@ -204,7 +204,7 @@ class Operation : public boost::intrusive_ref_counter<
   void dump_brief(ceph::Formatter *f);
   virtual ~Operation() = default;
 
- protected:
+ private:
   virtual void dump_detail(ceph::Formatter *f) const = 0;
 
  private:
@@ -235,10 +235,6 @@ std::ostream &operator<<(std::ostream &, const Operation &op);
 
 template <typename T>
 class OperationT : public Operation {
-
-protected:
-  virtual void dump_detail(ceph::Formatter *f) const = 0;
-
 public:
   static constexpr const char *type_name = OP_NAMES[static_cast<int>(T::type)];
   using IRef = boost::intrusive_ptr<T>;
@@ -252,6 +248,9 @@ public:
   }
 
   virtual ~OperationT() = default;
+
+private:
+  virtual void dump_detail(ceph::Formatter *f) const = 0;
 };
 
 /**