From: Willem Jan Withagen <wjw@digiware.nl>
Date: Mon, 5 Oct 2020 22:47:05 +0000 (+0200)
Subject: mds,osd: fix clang warnings to prevent unneeded copies
X-Git-Tag: v16.1.0~795^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F37557%2Fhead;p=ceph.git

mds,osd: fix clang warnings to prevent unneeded copies

/home/jenkins/workspace/ceph-master-compile/src/osd/OSDMap.cc:3901:19: warning: loop variable 'pg' of type 'const std::__1::pair<const pg_t, int>' creates a copy from type 'const std::__1::pair<const pg_t, int>' [-Wrange-loop-construct]
  for (const auto pg : *primary_temp)
                  ^
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
---

diff --git a/src/mds/SimpleLock.h b/src/mds/SimpleLock.h
index dd4367905679..5c625b6af06f 100644
--- a/src/mds/SimpleLock.h
+++ b/src/mds/SimpleLock.h
@@ -291,7 +291,7 @@ public:
   }
 
   void init_gather() {
-    for (const auto p : parent->get_replicas()) {
+    for (const auto& p : parent->get_replicas()) {
       more()->gather_set.insert(p.first);
     }
   }
diff --git a/src/osd/OSDMap.cc b/src/osd/OSDMap.cc
index 196a6ea39b66..7cafea2ad1bd 100644
--- a/src/osd/OSDMap.cc
+++ b/src/osd/OSDMap.cc
@@ -3898,7 +3898,7 @@ void OSDMap::print(ostream& out) const
   for (const auto& pg : *pg_temp)
     out << "pg_temp " << pg.first << " " << pg.second << "\n";
 
-  for (const auto pg : *primary_temp)
+  for (const auto& pg : *primary_temp)
     out << "primary_temp " << pg.first << " " << pg.second << "\n";
 
   for (const auto &addr : blocklist)