From: Ronen Friedman <rfriedma@redhat.com>
Date: Thu, 5 Nov 2020 08:38:37 +0000 (+0200)
Subject: librbd: removing a "pessimizing move"
X-Git-Tag: v16.1.0~655^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F37958%2Fhead;p=ceph.git

librbd: removing a "pessimizing move"

Silencing a compiler warning ("warning: moving a temporary object
prevents copy elision")

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
---

diff --git a/src/librbd/cache/ObjectCacherObjectDispatch.cc b/src/librbd/cache/ObjectCacherObjectDispatch.cc
index 2fefb26af73..81d5a71885b 100644
--- a/src/librbd/cache/ObjectCacherObjectDispatch.cc
+++ b/src/librbd/cache/ObjectCacherObjectDispatch.cc
@@ -326,9 +326,9 @@ bool ObjectCacherObjectDispatch<I>::write(
   SnapContext snapc;
   if (io_context->write_snap_context()) {
     auto write_snap_context = *io_context->write_snap_context();
-    snapc = std::move(SnapContext(write_snap_context.first,
-                                  {write_snap_context.second.begin(),
-                                   write_snap_context.second.end()}));
+    snapc = SnapContext(write_snap_context.first,
+                        {write_snap_context.second.begin(),
+                         write_snap_context.second.end()});
   }
 
   m_image_ctx->image_lock.lock_shared();