From: Igor Fedotov <ifedotov@suse.com>
Date: Mon, 23 Nov 2020 12:29:32 +0000 (+0300)
Subject: blk: log is_valid_io() parameters when unsuccessful.
X-Git-Tag: v16.1.0~459^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F38240%2Fhead;p=ceph.git

blk: log is_valid_io() parameters when unsuccessful.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
---

diff --git a/src/blk/BlockDevice.cc b/src/blk/BlockDevice.cc
index 345d51fdb09f..6804ee50cbca 100644
--- a/src/blk/BlockDevice.cc
+++ b/src/blk/BlockDevice.cc
@@ -196,3 +196,20 @@ void BlockDevice::reap_ioc()
     --ioc_reap_count;
   }
 }
+
+bool BlockDevice::is_valid_io(uint64_t off, uint64_t len) const {
+  bool ret = (off % block_size == 0 &&
+    len % block_size == 0 &&
+    len > 0 &&
+    off < size &&
+    off + len <= size);
+
+  if (!ret) {
+    derr << __func__ << " " << std::hex
+         << off << "~" << len
+         << " block_size " << block_size
+         << " size " << size
+         << std::dec << dendl;
+  }
+  return ret;
+}
diff --git a/src/blk/BlockDevice.h b/src/blk/BlockDevice.h
index 8ed53e69266c..191eb8ec908a 100644
--- a/src/blk/BlockDevice.h
+++ b/src/blk/BlockDevice.h
@@ -272,13 +272,7 @@ public:
   virtual void close() = 0;
 
 protected:
-  bool is_valid_io(uint64_t off, uint64_t len) const {
-    return (off % block_size == 0 &&
-            len % block_size == 0 &&
-            len > 0 &&
-            off < size &&
-            off + len <= size);
-  }
+  bool is_valid_io(uint64_t off, uint64_t len) const;
 };
 
 #endif //CEPH_BLK_BLOCKDEVICE_H