From: Willem Jan Withagen Date: Fri, 27 Nov 2020 00:17:05 +0000 (+0100) Subject: librbd: remove unwanted std::move X-Git-Tag: v16.1.0~444^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F38313%2Fhead;p=ceph.git librbd: remove unwanted std::move Clang argues: ``` /home/jenkins/workspace/ceph-master-compile/src/librbd/migration/HttpClient.cc:463:16: warning: moving a temporary object prevents copy elision [-Wpessimizing-move] response = std::move(m_parser->release()); ^ /home/jenkins/workspace/ceph-master-compile/src/librbd/migration/HttpClient.cc:463:16: note: remove std::move call here response = std::move(m_parser->release()); ^~~~~~~~~~ ~ 1 warning generated. ``` Signed-off-by: Willem Jan Withagen --- diff --git a/src/librbd/migration/HttpClient.cc b/src/librbd/migration/HttpClient.cc index fff959cca001..0cc51ddd861b 100644 --- a/src/librbd/migration/HttpClient.cc +++ b/src/librbd/migration/HttpClient.cc @@ -460,7 +460,7 @@ private: if (work->header_only()) { m_parser.emplace(std::move(*m_header_parser)); } - response = std::move(m_parser->release()); + response = m_parser->release(); // basic response code handling in a common location int r = 0;