From: Kefu Chai <kchai@redhat.com>
Date: Fri, 19 Mar 2021 11:23:09 +0000 (+0800)
Subject: script/run-make.sh: quote targets with double quote
X-Git-Tag: v17.1.0~2557^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F40236%2Fhead;p=ceph.git

script/run-make.sh: quote targets with double quote

in
ceph-build/ceph-perf-pull-requests/config/definitions/ceph-perf-pull-requests.yml,
we pass "vstart-base crimson-osd" as the targets argument, but the
build() function in ceph/src/script/run-make.sh fails to quote them, so
they are expanded into two argument of `test -n`. hence it breaks like

src/script/run-make.sh: line 124: test: vstart-base: binary operator expected
make will run with option(s) -j40
Unknown argument vstart-base
Unknown argument crimson-osd

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/script/run-make.sh b/src/script/run-make.sh
index 7f50fafc9fa..9503b8b35bf 100755
--- a/src/script/run-make.sh
+++ b/src/script/run-make.sh
@@ -121,7 +121,7 @@ function configure() {
 
 function build() {
     local targets="$@"
-    if test -n $targets; then
+    if test -n "$targets"; then
         targets="--target $targets"
     fi
     $DRY_RUN cd build