From: Kefu Chai <kchai@redhat.com>
Date: Sat, 27 Mar 2021 03:14:34 +0000 (+0800)
Subject: pybind/mgr/mds_autoscaler: add type annotation
X-Git-Tag: v17.1.0~2428^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F40449%2Fhead;p=ceph.git

pybind/mgr/mds_autoscaler: add type annotation

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/src/mypy.ini b/src/mypy.ini
index 9413d529a6c36..620d4a9911d37 100755
--- a/src/mypy.ini
+++ b/src/mypy.ini
@@ -52,6 +52,9 @@ disallow_untyped_defs = True
 [mypy-localpool.*]
 disallow_untyped_defs = True
 
+[mypy-mds_autoscaler.*]
+disallow_untyped_defs = True
+
 [mypy-orchestrator.*]
 disallow_untyped_defs = True
 
diff --git a/src/pybind/mgr/mds_autoscaler/module.py b/src/pybind/mgr/mds_autoscaler/module.py
index 01a9df2f4a892..006d8547c9556 100644
--- a/src/pybind/mgr/mds_autoscaler/module.py
+++ b/src/pybind/mgr/mds_autoscaler/module.py
@@ -3,7 +3,7 @@ Automatically scale MDSs based on status of the file-system using the FSMap
 """
 
 import logging
-from typing import Optional, List, Set
+from typing import Any, Optional
 from mgr_module import MgrModule
 from ceph.deployment.service_spec import ServiceSpec
 import orchestrator
@@ -16,7 +16,7 @@ class MDSAutoscaler(orchestrator.OrchestratorClientMixin, MgrModule):
     """
     MDS autoscaler.
     """
-    def __init__(self, *args, **kwargs):
+    def __init__(self, *args: Any, **kwargs: Any) -> None:
         MgrModule.__init__(self, *args, **kwargs)
         self.set_mgr(self)
 
@@ -52,7 +52,7 @@ class MDSAutoscaler(orchestrator.OrchestratorClientMixin, MgrModule):
                 return fs['mdsmap']['max_mds']
         assert False
 
-    def verify_and_manage_mds_instance(self, fs_map: dict, fs_name: str):
+    def verify_and_manage_mds_instance(self, fs_map: dict, fs_name: str) -> None:
         assert fs_map is not None
 
         try:
@@ -84,7 +84,7 @@ class MDSAutoscaler(orchestrator.OrchestratorClientMixin, MgrModule):
             self.log.exception(f"fs {fs_name}: exception while updating service: {e}")
             pass
 
-    def notify(self, notify_type, notify_id):
+    def notify(self, notify_type: str, notify_id: str) -> None:
         if notify_type != 'fs_map':
             return
         fs_map = self.get('fs_map')