From: Aashish Sharma <aashishsharma@localhost.localdomain>
Date: Wed, 26 May 2021 07:08:33 +0000 (+0530)
Subject: test,cmake:remove run-promtool-unitests.sh script
X-Git-Tag: v17.1.0~1800^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F41597%2Fhead;p=ceph.git

test,cmake:remove run-promtool-unitests.sh script

This PR intends to remove the run-promtool-unittests.sh script as CMakeLists.txt handles the promtool execution
(also adding the description to run these tests in Readme.md)

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
---

diff --git a/src/test/CMakeLists.txt b/src/test/CMakeLists.txt
index 43c449c02264..0d64ae7f7621 100644
--- a/src/test/CMakeLists.txt
+++ b/src/test/CMakeLists.txt
@@ -620,10 +620,7 @@ if(PROMTOOL_EXECUTABLE)
       "please use a newer prometheus")
   endif()
 else()
-  if(LINUX)
-    add_ceph_test(run-promtool-unittests
-      {CMAKE_CURRENT_SOURCE_DIR}/run-promtool-unittests.sh)
-  endif()
+  message(WARNING "run-promtool-unittests is skipped due to missing promtool")
 endif()
 
 set_property(
diff --git a/src/test/run-promtool-unittests.sh b/src/test/run-promtool-unittests.sh
deleted file mode 100755
index 84fc1d7d3ccd..000000000000
--- a/src/test/run-promtool-unittests.sh
+++ /dev/null
@@ -1,13 +0,0 @@
-#!/usr/bin/env bash
-
-set -ex
-
-SCRIPTPATH="$( cd "$(dirname "$0")" ; pwd -P )"
-: ${CEPH_ROOT:=$SCRIPTPATH/../../}
-
-sudo docker run --rm \
-         -v "$CEPH_ROOT":/ceph \
-         --name=promtool \
-         --network=host \
-         dnanexus/promtool:2.9.2 \
-         test rules /ceph/monitoring/prometheus/alerts/test_alerts.yml