From: Sébastien Han <seb@redhat.com>
Date: Mon, 28 Jun 2021 16:49:15 +0000 (+0200)
Subject: src/ceph-crash.in: print stderr if available
X-Git-Tag: v17.1.0~1451^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F42055%2Fhead;p=ceph.git

src/ceph-crash.in: print stderr if available

This is not perfect, but we have seen cases where the CLI returns 0 even
on failure.
For instance:

```sh
[root@rook-ceph-crashcollector-compute-1-66bdfbd886-d2zcd /]# ceph -n client.crash crash post -i /var/lib/ceph/crash/2021-06-28T07\:47\:37.859766Z_6ffb119c-930e-4047-9cfa-a92af783cdd0/meta
malformed crash metadata: time data '2021-06-28T07:47:37.859766' does not match format '%Y-%m-%d %H:%M:%S.%f'
[root@rook-ceph-crashcollector-compute-1-66bdfbd886-d2zcd /]# echo $?
0
```

So until we find the root cause, let's mitigate and perhaps accomodate
for futur similar issues.

Signed-off-by: Sébastien Han <seb@redhat.com>
---

diff --git a/src/ceph-crash.in b/src/ceph-crash.in
index 9e1e11181fbc..ae0e4f516464 100755
--- a/src/ceph-crash.in
+++ b/src/ceph-crash.in
@@ -51,7 +51,7 @@ def post_crash(path):
         stderr = pr.communicate(input=f.read())
         rc = pr.wait()
         f.close()
-        if rc != 0:
+        if rc != 0 or stderr != "":
             log.warning('post %s as %s failed: %s' % (path, n, stderr))
         if rc == 0:
             break