From: Sage Weil <sage@newdream.net>
Date: Wed, 30 Jun 2021 13:03:13 +0000 (-0400)
Subject: mgr/ActivePyModules: streamline mgr_ips a bit
X-Git-Tag: v17.1.0~1505^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F42107%2Fhead;p=ceph.git

mgr/ActivePyModules: streamline mgr_ips a bit

Signed-off-by: Sage Weil <sage@newdream.net>
---

diff --git a/src/mgr/ActivePyModules.cc b/src/mgr/ActivePyModules.cc
index a5589062e99d..4981a53b8db1 100644
--- a/src/mgr/ActivePyModules.cc
+++ b/src/mgr/ActivePyModules.cc
@@ -432,11 +432,9 @@ PyObject *ActivePyModules::get_python(const std::string &what)
     std::set<std::string> did;
     for (auto& i : myaddrs.v) {
       std::string ip = i.ip_only_to_str();
-      if (did.count(ip)) {
-	continue;
+      if (auto [where, inserted] = did.insert(ip); inserted) {
+	f.dump_string("ip", ip);
       }
-      did.insert(ip);
-      f.dump_string("ip", ip);
     }
     f.close_section();
     return f.get();