From: Willem Jan Withagen Date: Wed, 11 Aug 2021 08:47:45 +0000 (+0200) Subject: rgw/store: Do not init var-length arrays X-Git-Tag: v17.1.0~1119^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F42744%2Fhead;p=ceph.git rgw/store: Do not init var-length arrays Clang does nog like to init dynamic sized array: ``` src/rgw/store/dbstore/sqlite/sqliteDB.cc:334:13: error: variable-sized object may not be initialized char data[datalen+1] = {}; ^~~~~~~~~ 1 error generated. ``` Signed-off-by: Willem Jan Withagen --- diff --git a/src/rgw/store/dbstore/sqlite/sqliteDB.cc b/src/rgw/store/dbstore/sqlite/sqliteDB.cc index fdd53290ec5..0a2d323112b 100644 --- a/src/rgw/store/dbstore/sqlite/sqliteDB.cc +++ b/src/rgw/store/dbstore/sqlite/sqliteDB.cc @@ -331,9 +331,12 @@ static int get_objectdata(const DoutPrefixProvider *dpp, DBOpInfo &op, sqlite3_s blob = sqlite3_column_blob(stmt, 3); datalen = sqlite3_column_bytes(stmt, 3); - char data[datalen+1] = {}; - if (blob) + char data[datalen+1]; + data[0] = '\0'; + if (blob) { strncpy(data, (const char *)blob, datalen); + data[datalen] = '\0'; + } return 0; }