From: Kefu Chai <kchai@redhat.com>
Date: Tue, 7 Apr 2015 10:29:35 +0000 (+0800)
Subject: man: enable warning msgs for "all" target
X-Git-Tag: v9.0.0~24^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F4291%2Fhead;p=ceph.git

man: enable warning msgs for "all" target

* and remove `local-check` target. because we have killed all warnings,
  and `make check` depends on `am-all` actually. so previously, `make check`
  basically does nothing at all for validating the man pages' syntax.
  `make all` has rendered them already.
* do not run sphinx-build if $(top_srcdir)/doc/man does not exist. this
  is exactly the case of `make install` from a dist tarball.
* remove generated man pages in `make maintainer-clean` not in `make
  clean`, because we don't ship .rst files in the dist tarball.

Signed-off-by: Kefu Chai <kchai@redhat.com>
---

diff --git a/man/Makefile.am b/man/Makefile.am
index f7b4dac671de..ed59328ef39b 100644
--- a/man/Makefile.am
+++ b/man/Makefile.am
@@ -12,17 +12,18 @@ if ENABLE_SERVER
 include Makefile-server.am
 endif
 
-check-local:
-	${SPHINX_BUILD} -b man -d doctrees -c . $(top_srcdir)/doc/man $(top_builddir)/man
-
 # prevent `make` from running in parallel, sphinx runs better in batch mode.
 .PHONY: sphinx-build.stamp
 
 $(dist_man_MANS): sphinx-build.stamp
 
+# in a tree populated from dist tarball, the $(top_srcdir)/doc is not included
 sphinx-build.stamp:
-	${SPHINX_BUILD} -Q -b man -d doctrees -c . $(top_srcdir)/doc/man $(top_builddir)/man
+	if [ -d $(top_srcdir)/doc/man ] ; then \
+		${SPHINX_BUILD} -b man -d doctrees -c . $(top_srcdir)/doc/man $(top_builddir)/man; \
+	fi
 
 clean-local:
-	@rm -f *.8
 	@rm -rf doctrees
+
+MAINTAINERCLEANFILES = $(dist_man_MANS)