From: Greg Farnum <gfarnum@redhat.com>
Date: Tue, 31 Aug 2021 20:18:49 +0000 (+0000)
Subject: crimson: osd: do not capture std::error_code by reference
X-Git-Tag: v17.1.0~977^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F43003%2Fhead;p=ceph.git

crimson: osd: do not capture std::error_code by reference

I can't find any reason to assume it has a longer lifetime than
the future we're creating has.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
---

diff --git a/src/crimson/osd/pg.cc b/src/crimson/osd/pg.cc
index fbebbc4b8158..704b6bf563a5 100644
--- a/src/crimson/osd/pg.cc
+++ b/src/crimson/osd/pg.cc
@@ -716,7 +716,7 @@ PG::do_osd_ops_execute(
             [rollbacker, failure_func_ptr]
             (const std::error_code& e) mutable {
             return rollbacker.rollback_obc_if_modified(e).then_interruptible(
-              [&e, failure_func_ptr] {
+              [e, failure_func_ptr] {
               return (*failure_func_ptr)(e);
             });
           })
@@ -728,7 +728,7 @@ PG::do_osd_ops_execute(
     return PG::do_osd_ops_iertr::make_ready_future<pg_rep_op_fut_t<Ret>>(
         seastar::now(),
         rollbacker.rollback_obc_if_modified(e).then_interruptible(
-          [&e, failure_func_ptr] {
+          [e, failure_func_ptr] {
           return (*failure_func_ptr)(e);
         }));
   }));