From: Sebastian Wagner <sewagner@redhat.com>
Date: Fri, 3 Sep 2021 09:38:04 +0000 (+0200)
Subject: qa/tox.ini: check for dead symlinks
X-Git-Tag: v17.1.0~957^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F43040%2Fhead;p=ceph.git

qa/tox.ini: check for dead symlinks

IMO the amount of symlinks we have to manually maintain
is tedious and error prone. Any ideas on improving thing?

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
---

diff --git a/qa/CMakeLists.txt b/qa/CMakeLists.txt
index 884c41e4bba..b8d4872ac0e 100644
--- a/qa/CMakeLists.txt
+++ b/qa/CMakeLists.txt
@@ -5,5 +5,5 @@ endif()
 
 if(WITH_TESTS)
   include(AddCephTest)
-  add_tox_test(qa TOX_ENVS py3 flake8 mypy)
+  add_tox_test(qa TOX_ENVS py3 flake8 mypy deadsymlinks)
 endif()
diff --git a/qa/suites/rgw-multisite-upgrade/.qa b/qa/suites/rgw-multisite-upgrade/.qa
new file mode 120000
index 00000000000..fea2489fdf6
--- /dev/null
+++ b/qa/suites/rgw-multisite-upgrade/.qa
@@ -0,0 +1 @@
+../.qa
\ No newline at end of file
diff --git a/qa/tox.ini b/qa/tox.ini
index 1046597ac16..6d5ae7ecba6 100644
--- a/qa/tox.ini
+++ b/qa/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = flake8, mypy, pytest
+envlist = flake8, mypy, pytest, deadsymlinks
 skipsdist = True
 
 [testenv:flake8]
@@ -31,3 +31,10 @@ commands =
   pytest --assert=plain test_import.py
   pytest tasks/tests
 
+[testenv:deadsymlinks]
+basepython = python3
+toxworkdir = {toxinidir}
+allowlist_externals = 
+  bash
+commands =
+  bash -c '! (find . -xtype l | grep ^)'