From: Radoslaw Zarzynski Date: Wed, 2 Mar 2022 15:14:29 +0000 (+0000) Subject: test/cls_lua: don't append uninitialized memory to bufferlist. X-Git-Tag: v18.0.0~1225^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F45221%2Fhead;p=ceph.git test/cls_lua: don't append uninitialized memory to bufferlist. This is intended to fix the following compiler's warnings: ``` [1115/1786] Building CXX object src/test/cls_lua/CMakeFiles/ceph_test_cls_lua.dir/test_cls_lua.cc.o ../src/test/cls_lua/test_cls_lua.cc: In member function ‘virtual void ClsLua_Stat_Test::TestBody()’: ../src/test/cls_lua/test_cls_lua.cc:685:12: warning: ‘buf’ may be used uninitialized [-Wmaybe-uninitialized] 685 | bl.append(buf, sizeof(buf)); | ~~~~~~~~~^~~~~~~~~~~~~~~~~~ In file included from ../src/include/encoding.h:38, from ../src/include/uuid.h:9, from ../src/include/types.h:21, from ../src/test/cls_lua/test_cls_lua.cc:3: ../src/include/buffer.h:1124:10: note: by argument 2 of type ‘const char*’ to ‘void ceph::buffer::v15_2_0::list::append(const char*, unsigned int)’ declared here 1124 | void append(const char *data, unsigned len); | ^~~~~~ ../src/test/cls_lua/test_cls_lua.cc:683:8: note: ‘buf’ declared here 683 | char buf[1024]; | ^~~ ../src/test/cls_lua/test_cls_lua.cc: In member function ‘virtual void ClsLua_WriteFull_Test::TestBody()’: ../src/test/cls_lua/test_cls_lua.cc:893:14: warning: ‘buf’ may be used uninitialized [-Wmaybe-uninitialized] 893 | blin.append(buf, sizeof(buf)); | ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ In file included from ../src/include/encoding.h:38, from ../src/include/uuid.h:9, from ../src/include/types.h:21, from ../src/test/cls_lua/test_cls_lua.cc:3: ../src/include/buffer.h:1124:10: note: by argument 2 of type ‘const char*’ to ‘void ceph::buffer::v15_2_0::list::append(const char*, unsigned int)’ declared here 1124 | void append(const char *data, unsigned len); | ^~~~~~ ../src/test/cls_lua/test_cls_lua.cc:891:8: note: ‘buf’ declared here 891 | char buf[1024]; ``` Signed-off-by: Radoslaw Zarzynski --- diff --git a/src/test/cls_lua/test_cls_lua.cc b/src/test/cls_lua/test_cls_lua.cc index 516b4c9ae00..a7d09aba464 100644 --- a/src/test/cls_lua/test_cls_lua.cc +++ b/src/test/cls_lua/test_cls_lua.cc @@ -680,7 +680,7 @@ TEST_F(ClsLua, Remove) { TEST_F(ClsLua, Stat) { /* build object and stat */ - char buf[1024]; + char buf[1024] = {}; bufferlist bl; bl.append(buf, sizeof(buf)); ASSERT_EQ(0, ioctx.write_full(oid, bl)); @@ -888,7 +888,7 @@ TEST_F(ClsLua, SetXattr) { TEST_F(ClsLua, WriteFull) { // write some data - char buf[1024]; + char buf[1024] = {}; bufferlist blin; blin.append(buf, sizeof(buf)); ASSERT_EQ(0, ioctx.write(oid, blin, blin.length(), 0));