From: Redouane Kachach <rkachach@redhat.com>
Date: Wed, 9 Mar 2022 13:19:02 +0000 (+0100)
Subject: mgr/cephadm: checking service name before removal
X-Git-Tag: v18.0.0~1190^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F45314%2Fhead;p=ceph.git

mgr/cephadm: checking service name before removal
Fixes: https://tracker.ceph.com/issues/54503

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
---

diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py
index 0bba96b8c51..3bc9a46b273 100644
--- a/src/pybind/mgr/cephadm/module.py
+++ b/src/pybind/mgr/cephadm/module.py
@@ -1975,6 +1975,8 @@ Then run the following:
             if self.spec_store[service_name].spec.service_type in ('mon', 'mgr'):
                 return f'Unable to remove {service_name} service.\n' \
                        f'Note, you might want to mark the {service_name} service as "unmanaged"'
+        else:
+            return f"Invalid service '{service_name}'. Use 'ceph orch ls' to list available services.\n"
 
         # Report list of affected OSDs?
         if not force and service_name.startswith('osd.'):