From: Kefu Chai <tchaikov@gmail.com>
Date: Fri, 25 Mar 2022 15:02:59 +0000 (+0800)
Subject: crimson/os: use fmt::format() instead of sstream
X-Git-Tag: v18.0.0~1178^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F45649%2Fhead;p=ceph.git

crimson/os: use fmt::format() instead of sstream

for better readability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
---

diff --git a/src/crimson/os/seastore/journal/segment_allocator.cc b/src/crimson/os/seastore/journal/segment_allocator.cc
index 9f3a16efbc03..1d805ce2678e 100644
--- a/src/crimson/os/seastore/journal/segment_allocator.cc
+++ b/src/crimson/os/seastore/journal/segment_allocator.cc
@@ -3,7 +3,7 @@
 
 #include "segment_allocator.h"
 
-#include <sstream>
+#include <fmt/format.h>
 
 #include "crimson/os/seastore/logging.h"
 #include "crimson/os/seastore/segment_cleaner.h"
@@ -18,14 +18,12 @@ SegmentAllocator::SegmentAllocator(
   SegmentProvider &sp,
   SegmentManager &sm)
   : name{name},
+    print_name{fmt::format("D?_{}", name)},
     type{type},
     segment_provider{sp},
     segment_manager{sm}
 {
   ceph_assert(type != segment_type_t::NULL_SEG);
-  std::ostringstream oss;
-  oss << "D?_" << name;
-  print_name = oss.str();
   reset();
 }
 
@@ -118,9 +116,9 @@ SegmentAllocator::open_ret
 SegmentAllocator::open()
 {
   LOG_PREFIX(SegmentAllocator::open);
-  std::ostringstream oss;
-  oss << "D" << device_id_printer_t{get_device_id()} << "_" << name;
-  print_name = oss.str();
+  print_name = fmt::format("D{}_{}",
+                           device_id_printer_t{get_device_id()},
+                           name);
   INFO("{}", print_name);
   return do_open();
 }