From: Adam C. Emerson <aemerson@redhat.com>
Date: Fri, 8 Jul 2022 18:58:16 +0000 (-0400)
Subject: rgw: Guard against malformed bucket URLs
X-Git-Tag: v18.0.0~496^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F47025%2Fhead;p=ceph.git

rgw: Guard against malformed bucket URLs

Misplaced colons can result in radosgw thinking is has a bucket URL
but with no bucket name, leading to a crash later on.

Fixes: https://tracker.ceph.com/issues/55765
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
---

diff --git a/src/rgw/rgw_common.cc b/src/rgw/rgw_common.cc
index 96eded1f56a9..54869a0d7cf0 100644
--- a/src/rgw/rgw_common.cc
+++ b/src/rgw/rgw_common.cc
@@ -1349,6 +1349,11 @@ bool verify_bucket_permission_no_policy(const DoutPrefixProvider* dpp, req_state
 
 bool verify_bucket_permission(const DoutPrefixProvider* dpp, req_state * const s, const uint64_t op)
 {
+  if (rgw::sal::Bucket::empty(s->bucket)) {
+    // request is missing a bucket name
+    return false;
+  }
+
   perm_state_from_req_state ps(s);
 
   return verify_bucket_permission(dpp,