From: Sébastien Han <seb@redhat.com>
Date: Sun, 10 Jan 2016 15:52:37 +0000 (+0100)
Subject: Fix firewall check
X-Git-Tag: v1.0.0~71^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F471%2Fhead;p=ceph-ansible.git

Fix firewall check

Use command module instead of shell since we do not do anything fancy
here. Remove the duplicate register.

Signed-off-by: Sébastien Han <seb@redhat.com>
---

diff --git a/roles/ceph-common/tasks/checks/check_firewall.yml b/roles/ceph-common/tasks/checks/check_firewall.yml
index 632a85605..a04b98e95 100644
--- a/roles/ceph-common/tasks/checks/check_firewall.yml
+++ b/roles/ceph-common/tasks/checks/check_firewall.yml
@@ -1,6 +1,6 @@
 ---
 - name: check if nmap is installed
-  shell: "command -v nmap"
+  command: "command -v nmap"
   changed_when: false
   failed_when: false
   register: nmapexist
@@ -16,7 +16,6 @@
   failed_when: false
   with_items: groups.{{ mon_group_name }}
   register: monportstate
-  register: monportstate
   when: mon_group_name in group_names
 
 - name: fail if monitor port is filtered