From: Casey Bodley <cbodley@redhat.com>
Date: Mon, 7 Mar 2022 20:10:07 +0000 (-0500)
Subject: rgw: initialize RGWIndexCompletionManager thread after related members
X-Git-Tag: v16.2.15~59^2
X-Git-Url: http://git.apps.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F49093%2Fhead;p=ceph.git

rgw: initialize RGWIndexCompletionManager thread after related members

resolves valgrind issues about RGWIndexCompletionManager::process()
using uninitialized memory

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 112c2608750cf8db2c52c8e89f5897080501f6bd)
---

diff --git a/src/rgw/rgw_rados.cc b/src/rgw/rgw_rados.cc
index ab98b5ffa21c6..2885a4af02f94 100644
--- a/src/rgw/rgw_rados.cc
+++ b/src/rgw/rgw_rados.cc
@@ -795,11 +795,10 @@ class RGWIndexCompletionManager {
   std::vector<set<complete_op_data*>> completions;
   std::vector<complete_op_data*> retry_completions;
 
-  std::thread retry_thread;
   std::condition_variable cond;
   std::mutex retry_completions_lock;
-
   bool _stop{false};
+  std::thread retry_thread;
 
   std::atomic<int> cur_shard {0};