From: Kefu Chai Date: Sun, 18 Dec 2022 02:47:42 +0000 (+0800) Subject: cmake: set WITH_FMT_VERSION as a STRING option X-Git-Tag: v18.1.0~627^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F49489%2Fhead;p=ceph.git cmake: set WITH_FMT_VERSION as a STRING option option() defines a boolean, so its default value cannot be populated to find_package() as expected. so we need to set it as a cached STRING variable. this addresses the regression introduced by 051ec194df16927187cbe4b26dacd06c31fa186a Signed-off-by: Kefu Chai --- diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index f29d173b3cdf..e3aa15f4638e 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -321,7 +321,8 @@ if(NOT TARGET RapidJSON::RapidJSON) endif() option(WITH_FMT_HEADER_ONLY "use header-only version of fmt library" OFF) -option(WITH_FMT_VERSION "build with fmt version" 7.0.0) +set(WITH_FMT_VERSION "7.0.0" CACHE + STRING "build with fmt version") find_package(fmt ${WITH_FMT_VERSION} QUIET) if(fmt_FOUND) include_directories(SYSTEM "${fmt_INCLUDE_DIR}")