From: John Mulligan <jmulligan@redhat.com>
Date: Thu, 30 Mar 2023 20:49:27 +0000 (-0400)
Subject: python-common: add a dedicated tox env to run mypy
X-Git-Tag: v19.0.0~1447^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F50743%2Fhead;p=ceph.git

python-common: add a dedicated tox env to run mypy

IMO it's not a good practice to overload a tox rule with multiple
different test tools. It forces the tools to share the same virtualenvs
and makes it impossible to run the tools individually. A separate mypy
env also better matches the other tox.ini files in the ceph tree.
Since the new 'mypy' env is in the default env list it will continue
to get run automatically when no specific envs are selected.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
---

diff --git a/src/python-common/tox.ini b/src/python-common/tox.ini
index 0699c0476526..2737a87e8207 100644
--- a/src/python-common/tox.ini
+++ b/src/python-common/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py3, lint
+envlist = py3, mypy, lint
 skip_missing_interpreters = true
 
 [testenv:py3]
@@ -11,6 +11,13 @@ commands=
     pytest {posargs}
     mypy --config-file=../mypy.ini -p ceph
 
+[testenv:mypy]
+deps=
+    -rrequirements.txt
+    -c{toxinidir}/../mypy-constrains.txt
+commands=
+    mypy --config-file=../mypy.ini -p ceph
+
 [tool:pytest]
 norecursedirs = .* _* virtualenv