From: Xuehan Xu <xxhdx1985126@gmail.com>
Date: Thu, 27 Apr 2023 03:32:04 +0000 (+0000)
Subject: crimson/osd/snaptrim_event: avoid leaking txn ops for updating head obcs
X-Git-Tag: v19.0.0~1310^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F51180%2Fhead;p=ceph.git

crimson/osd/snaptrim_event: avoid leaking txn ops for updating head obcs
when removing clones

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
---

diff --git a/src/crimson/osd/osd_operations/snaptrim_event.cc b/src/crimson/osd/osd_operations/snaptrim_event.cc
index 9b67f23ecca4..e184cdb0e01f 100644
--- a/src/crimson/osd/osd_operations/snaptrim_event.cc
+++ b/src/crimson/osd/osd_operations/snaptrim_event.cc
@@ -431,7 +431,7 @@ SnapTrimObjSubEvent::remove_or_update(
     }
   }
 
-  return seastar::do_with(ceph::os::Transaction{}, [=, this](auto&& txn) {
+  return seastar::do_with(ceph::os::Transaction{}, [=, this](auto &txn) {
   std::vector<pg_log_entry_t> log_entries{};
 
   int64_t num_objects_before_trim = delta_stats.num_objects;
@@ -467,7 +467,7 @@ SnapTrimObjSubEvent::remove_or_update(
       //add_objects_trimmed_count(num_objects_trimmed);
     }
   }).safe_then_interruptible(
-    [txn=std::move(txn), log_entries=std::move(log_entries)] () mutable {
+    [&txn, log_entries=std::move(log_entries)] () mutable {
     return remove_or_update_iertr::make_ready_future<remove_or_update_ret_t>(
       std::make_pair(std::move(txn), std::move(log_entries)));
   });