From: Matan Breizman Date: Wed, 3 May 2023 09:39:14 +0000 (+0000) Subject: crimson/osd/objclass: Compilation warning X-Git-Tag: v19.0.0~1278^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F51333%2Fhead;p=ceph.git crimson/osd/objclass: Compilation warning ``` In copy constructor ‘ceph::buffer::v15_2_0::list::list(const ceph::buffer::v15_2_0::list&)’, inlined from ‘OSDOp::OSDOp(const OSDOp&)’ at ../src/osd/osd_types.h:4081:8, inlined from ‘int cls_cxx_snap_revert(cls_method_context_t, snapid_t)’ at ../src/crimson/osd/objclass.cc:279:37: ../src/include/buffer.h:945:20: warning: ‘op.OSDOp::indata.ceph::buffer::v15_2_0::list::_len’ is used uninitialized [-Wuninitialized] 945 | _len(other._len), | ~~~~~~^~~~ ../src/crimson/osd/objclass.cc: In function ‘int cls_cxx_snap_revert(cls_method_context_t, snapid_t)’: ../src/crimson/osd/objclass.cc:279:9: note: ‘op’ declared here 279 | OSDOp op{op = CEPH_OSD_OP_ROLLBACK}; | ``` Signed-off-by: Matan Breizman --- diff --git a/src/crimson/osd/objclass.cc b/src/crimson/osd/objclass.cc index d6d2e914a7b97..4cc9d73369d67 100644 --- a/src/crimson/osd/objclass.cc +++ b/src/crimson/osd/objclass.cc @@ -276,7 +276,7 @@ int cls_cxx_setxattr(cls_method_context_t hctx, int cls_cxx_snap_revert(cls_method_context_t hctx, snapid_t snapid) { - OSDOp op{op = CEPH_OSD_OP_ROLLBACK}; + OSDOp op{CEPH_OSD_OP_ROLLBACK}; op.op.snap.snapid = snapid; return execute_osd_op(hctx, op); }