From: Matan Breizman <mbreizma@redhat.com>
Date: Sun, 7 May 2023 13:29:22 +0000 (+0000)
Subject: crimson/osd/osd_operations/client_request: Fix client blocklisting
X-Git-Tag: v19.0.0~1268^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F51381%2Fhead;p=ceph.git

crimson/osd/osd_operations/client_request: Fix client blocklisting

See #50835.
In crimson, conn is independently maintained outside Message.
Therefore, when trying to use the message's connection for `get_peer_addr()`
we won't be able to get the peer address.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
---

diff --git a/src/crimson/osd/osd_operations/client_request.cc b/src/crimson/osd/osd_operations/client_request.cc
index d23a82ab0524..9be2108bc9f0 100644
--- a/src/crimson/osd/osd_operations/client_request.cc
+++ b/src/crimson/osd/osd_operations/client_request.cc
@@ -272,8 +272,8 @@ ClientRequest::do_process(
     return reply_op_error(pg, -ENAMETOOLONG);
   } else if (m->get_hobj().oid.name.empty()) {
     return reply_op_error(pg, -EINVAL);
-  } else if (pg->get_osdmap()->is_blocklisted(m->get_source_addr())) {
-    logger().info("{} is blocklisted", m->get_source_addr());
+  } else if (pg->get_osdmap()->is_blocklisted(conn->get_peer_addr())) {
+    logger().info("{} is blocklisted", conn->get_peer_addr());
     return reply_op_error(pg, -EBLOCKLISTED);
   }