From: Kefu Chai <tchaikov@gmail.com>
Date: Fri, 15 Dec 2023 10:18:01 +0000 (+0800)
Subject: cmake: differentiate WITH_CEPHFS from WITH_LIBCEPHFS
X-Git-Tag: v19.3.0~346^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F54917%2Fhead;p=ceph.git

cmake: differentiate WITH_CEPHFS from WITH_LIBCEPHFS

WITH_CEPHFS is used for enabling the server side of cephfs, i.e., mds,
while WITH_LIBCEPHFS is for the client side of it, namely libcephfs
and its python bindings. since we have these two different options,
in theory, user is allowed to build with WITH_CEPHFS=ON and
WITH_LIBCEPHFS=OFF, and in that case, `vstart` should not depend on
the non-existent target of cephfs and cython_cephfs. the same applies to
the build of cython_cephfs. this is an unusual combination, but
it is a valid one.

in this change, we

* build the python binding only if WITH_LIBCEPHFS is ON
* add cephfs and cython_cephfs as dependencies of vstart only if
  WITH_LIBCEPHFS is ON

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
---

diff --git a/src/pybind/CMakeLists.txt b/src/pybind/CMakeLists.txt
index b01c49b6215a..fb357700a470 100644
--- a/src/pybind/CMakeLists.txt
+++ b/src/pybind/CMakeLists.txt
@@ -12,7 +12,7 @@ if(WITH_RBD)
   add_subdirectory(rbd)
   add_dependencies(cython_modules cython_rbd)
 endif()
-if(WITH_CEPHFS)
+if(WITH_LIBCEPHFS)
   add_subdirectory(cephfs)
   add_dependencies(cython_modules cython_cephfs)
 endif()