From: Sage Weil <sage@redhat.com>
Date: Fri, 4 Sep 2015 02:01:19 +0000 (-0400)
Subject: osd/ReplicatedPG: ProxyWriteOp::reqid should not be a ref
X-Git-Tag: v9.1.0~223^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F5802%2Fhead;p=ceph.git

osd/ReplicatedPG: ProxyWriteOp::reqid should not be a ref

CID 1322778 (#1 of 1): Pointer to local outside scope (RETURN_LOCAL)
1. escape_local_addr: Returning, through this->reqid, the address of stack variable _reqid.
   	2. return: Returning here.

Signed-off-by: Sage Weil <sage@redhat.com>
---

diff --git a/src/osd/ReplicatedPG.h b/src/osd/ReplicatedPG.h
index 4517e68730eb..31491801ffc0 100644
--- a/src/osd/ReplicatedPG.h
+++ b/src/osd/ReplicatedPG.h
@@ -221,7 +221,7 @@ public:
     bool sent_ack;
     utime_t mtime;
     bool canceled;
-    osd_reqid_t &reqid;
+    osd_reqid_t reqid;
 
     ProxyWriteOp(OpRequestRef _op, hobject_t oid, vector<OSDOp>& _ops, osd_reqid_t _reqid)
       : ctx(NULL), op(_op), soid(oid),