From: Jim Curtis <jim.curtis@redhat.com>
Date: Tue, 6 Dec 2016 02:17:27 +0000 (-0800)
Subject: Review feedback
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F584%2Fhead;p=ceph-build.git

Review feedback
---

diff --git a/ansible/private-docker-registry/README.md b/ansible/private-docker-registry/README.md
index 287554f6..0e25cdae 100644
--- a/ansible/private-docker-registry/README.md
+++ b/ansible/private-docker-registry/README.md
@@ -17,7 +17,7 @@ push an image to the private docker registry on the other node.
 ## Running Vagrant to Provision and Test
 
 * Edit vagrant_variables.yml and change the `vagrant_box` variable if needed
-* Use `vsgrant up` command to deploy and provision the VMs
+* Use `vagrant up` command to deploy and provision the VMs
 
 When the playbook completes successfully, it will have started the private
 docker registry container and used the other VM to test pushing a test image
@@ -28,7 +28,7 @@ to that private docker container.
 When you are ready to provision onto an existing machine, first make sure
 that docker is installed on that machine.
 
-In the top directory of this playbook where the site.yml file exist, add
+In the top directory of this playbook where the `site.yml` file exist, add
 an `ansible-hosts` file to specify the machine you want to provision.  It
 should look something like this:
 
diff --git a/ansible/private-docker-registry/roles/docker-registry/tasks/main.yml b/ansible/private-docker-registry/roles/docker-registry/tasks/main.yml
index 5947b684..29550603 100644
--- a/ansible/private-docker-registry/roles/docker-registry/tasks/main.yml
+++ b/ansible/private-docker-registry/roles/docker-registry/tasks/main.yml
@@ -1,6 +1,8 @@
 ---
 - name: create directory for self-signed SSL cert
-  file: path=/var/registry/certs state=directory
+  file: 
+    path: /var/registry/certs 
+    state: directory
 
 - name: create self-signed cfssl json file
   template:
diff --git a/ansible/private-docker-registry/roles/test-client/tasks/main.yml b/ansible/private-docker-registry/roles/test-client/tasks/main.yml
index 34d22309..d4a07169 100644
--- a/ansible/private-docker-registry/roles/test-client/tasks/main.yml
+++ b/ansible/private-docker-registry/roles/test-client/tasks/main.yml
@@ -1,6 +1,8 @@
 ---
 - name: create directory for self-signed cert of docker-registry
-  file: path=/etc/docker/certs.d/{{ hostvars['docker-registry']['ansible_default_ipv4']['address'] }}:5000 state=directory
+  file: 
+    path: /etc/docker/certs.d/{{ hostvars['docker-registry']['ansible_default_ipv4']['address'] }}:5000 
+    state: directory
 
 - name: copy self-signed cert of docker-registry
   copy: