From: J. Eric Ivancich <ivancich@redhat.com>
Date: Tue, 2 Jul 2024 17:50:27 +0000 (-0400)
Subject: rgw: fix bucket sync thread waiting inordinate amount of time
X-Git-Tag: v20.0.0~1600^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F58403%2Fhead;p=ceph.git

rgw: fix bucket sync thread waiting inordinate amount of time

A signed value was read in as an unsigned value, so -1 was interpreted
as a very large value. This made the thread wait period in the bucket
sync thread inordinately long, preventing bucket sync and dynamic
resharding (unless values appropriate for debugging were set).

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
---

diff --git a/src/rgw/rgw_quota.cc b/src/rgw/rgw_quota.cc
index 377e8c747014..f55064ff53ff 100644
--- a/src/rgw/rgw_quota.cc
+++ b/src/rgw/rgw_quota.cc
@@ -363,7 +363,7 @@ class RGWOwnerStatsCache : public RGWQuotaCache<rgw_owner> {
       // option, so we can assume it won't change while the RGW server
       // is running, so we'll handle it once before we loop
       double sync_interval_factor = 1.0;
-      const uint64_t debug_interval = cct->_conf->rgw_reshard_debug_interval;
+      const int64_t debug_interval = cct->_conf->rgw_reshard_debug_interval;
       if (debug_interval >= 1) {
 	  constexpr double secs_per_day = 60 * 60 * 24;
 	  sync_interval_factor = debug_interval / secs_per_day;