From: Rishabh Dave Date: Wed, 26 Jun 2024 13:35:35 +0000 (+0530) Subject: qa/cephfs: fix test_single_path_authorize_on_nonalphanumeric_fsname X-Git-Tag: v18.2.5~513^2 X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F58560%2Fhead;p=ceph.git qa/cephfs: fix test_single_path_authorize_on_nonalphanumeric_fsname This test deletes the CephFS already present on the cluster at the very beginning and unmounts the first client beforehand. But it leaves the second client mounted on this deleted CephFS that doesn't exist for the rest of the test. And then at the very end of this test it attempts to remount the second client (during tearDown()) which hangs and causes test runner to crash. Unmount the second client beforehand to prevent the bug and delete mount_b object to avoid confusion for the readers in future about whether or not 2nd mountpoint exists. Fixes: https://tracker.ceph.com/issues/66077 Signed-off-by: Rishabh Dave (cherry picked from commit 2130ec8ebc377364a11be7448ed2773b46b464c0) --- diff --git a/qa/tasks/cephfs/test_admin.py b/qa/tasks/cephfs/test_admin.py index 6bf8afc73eef..d484a5bdf7be 100644 --- a/qa/tasks/cephfs/test_admin.py +++ b/qa/tasks/cephfs/test_admin.py @@ -1470,6 +1470,8 @@ class TestFsAuthorize(CephFSTestCase): characters """ self.mount_a.umount_wait(require_clean=True) + # let's unmount both client before deleting the FS + self.mount_b.umount_wait(require_clean=True) self.mds_cluster.delete_all_filesystems() fs_name = "cephfs-_." self.fs = self.mds_cluster.newfs(name=fs_name)