From: Gal Salomon <gal.salomon@gmail.com>
Date: Mon, 21 Oct 2024 19:12:26 +0000 (+0300)
Subject: remove the code-lines that checking the {ofs,len} bounderies; and modifies them if... 
X-Git-Tag: v20.0.0~753^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F59465%2Fhead;p=ceph.git

remove the code-lines that checking the {ofs,len} bounderies; and modifies them if necessary(invalid read)

Signed-off-by: Gal Salomon <gal.salomon@gmail.com>
---

diff --git a/src/rgw/rgw_s3select.cc b/src/rgw/rgw_s3select.cc
index f133f7f80169..f0b26824ca6b 100644
--- a/src/rgw/rgw_s3select.cc
+++ b/src/rgw/rgw_s3select.cc
@@ -806,11 +806,6 @@ int RGWSelectObj_ObjStore_S3::parquet_processing(bufferlist& bl, off_t ofs, off_
       }
       append_in_callback += it.length();
       ldout(s->cct, 10) << "S3select: part " << part_no++ << " it.length() = " << it.length() << dendl;
-      if ((ofs + len) > it.length()){
-	ldpp_dout(this, 10) << "s3select: offset and length may cause invalid read: ofs = " << ofs << " len = " << len << " it.length() = " << it.length() << dendl;
-	ofs = 0;
-	len = it.length();
-      }
       requested_buffer.append(&(it)[0]+ofs, len);
     }
     ldout(s->cct, 10) << "S3select:append_in_callback = " << append_in_callback << dendl;