From: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
Date: Wed, 15 Jan 2025 12:49:47 +0000 (+0530)
Subject: mgr/cephadm: After deploying nvmeof gateway group, the prometheus port 10008/tcp... 
X-Git-Tag: v20.0.0~328^2
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F61396%2Fhead;p=ceph.git

mgr/cephadm: After deploying nvmeof gateway group, the prometheus port 10008/tcp is not opened

Fixes: https://tracker.ceph.com/issues/69541
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
---

diff --git a/src/pybind/mgr/cephadm/tests/test_services.py b/src/pybind/mgr/cephadm/tests/test_services.py
index d872219df808..498b4bc53ba9 100644
--- a/src/pybind/mgr/cephadm/tests/test_services.py
+++ b/src/pybind/mgr/cephadm/tests/test_services.py
@@ -481,11 +481,11 @@ timeout = 1.0\n"""
                         "image": "",
                         "deploy_arguments": [],
                         "params": {
-                            "tcp_ports": [5500, 4420, 8009]
+                            "tcp_ports": [5500, 4420, 8009, 10008]
                         },
                         "meta": {
                             "service_name": "nvmeof.testpool",
-                            "ports": [5500, 4420, 8009],
+                            "ports": [5500, 4420, 8009, 10008],
                             "ip": None,
                             "deployed_by": [],
                             "rank": None,
diff --git a/src/python-common/ceph/deployment/service_spec.py b/src/python-common/ceph/deployment/service_spec.py
index 1ac9fa49e32e..7d87472beb6b 100644
--- a/src/python-common/ceph/deployment/service_spec.py
+++ b/src/python-common/ceph/deployment/service_spec.py
@@ -1550,7 +1550,7 @@ class NvmeofServiceSpec(ServiceSpec):
         self.monitor_client_log_file_dir = monitor_client_log_file_dir
 
     def get_port_start(self) -> List[int]:
-        return [self.port, 4420, self.discovery_port]
+        return [self.port, 4420, self.discovery_port, self.prometheus_port]
 
     def validate(self) -> None:
         #  TODO: what other parameters should be validated as part of this function?