From: Adam C. Emerson <aemerson@redhat.com>
Date: Thu, 3 Jul 2025 19:12:05 +0000 (-0400)
Subject: rgw/datalog: Stick noexcept on wrappers returning int
X-Git-Url: http://git-server-git.apps.pok.os.sepia.ceph.com/?a=commitdiff_plain;h=refs%2Fpull%2F62770%2Fhead;p=ceph.git

rgw/datalog: Stick noexcept on wrappers returning int

Easier to debug.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
---

diff --git a/src/rgw/driver/rados/rgw_datalog.cc b/src/rgw/driver/rados/rgw_datalog.cc
index 1328f15b8b3e..1a30a9808ebf 100644
--- a/src/rgw/driver/rados/rgw_datalog.cc
+++ b/src/rgw/driver/rados/rgw_datalog.cc
@@ -439,7 +439,7 @@ void DataLogBackends::handle_empty_to(uint64_t new_tail) {
 int RGWDataChangesLog::start(const DoutPrefixProvider *dpp,
 			     const RGWZone* zone,
 			     const RGWZoneParams& zoneparams,
-			     bool background_tasks)
+			     bool background_tasks) noexcept
 {
   log_data = zone->log_data;
   try {
@@ -1011,7 +1011,7 @@ void RGWDataChangesLog::add_entry(const DoutPrefixProvider* dpp,
 int RGWDataChangesLog::add_entry(const DoutPrefixProvider* dpp,
 				 const RGWBucketInfo& bucket_info,
 				 const rgw::bucket_log_layout_generation& gen,
-				 int shard_id, optional_yield y)
+				 int shard_id, optional_yield y) noexcept
 {
   try {
     if (y) {
diff --git a/src/rgw/driver/rados/rgw_datalog.h b/src/rgw/driver/rados/rgw_datalog.h
index 51f3b19584d9..ae013e2fdef4 100644
--- a/src/rgw/driver/rados/rgw_datalog.h
+++ b/src/rgw/driver/rados/rgw_datalog.h
@@ -449,7 +449,7 @@ public:
 			      bool recovery, bool watch, bool renew);
 
   int start(const DoutPrefixProvider *dpp, const RGWZone* _zone,
-	    const RGWZoneParams& zoneparams, bool background_tasks);
+	    const RGWZoneParams& zoneparams, bool background_tasks) noexcept;
   asio::awaitable<bool> establish_watch(const DoutPrefixProvider* dpp,
 					std::string_view oid);
   asio::awaitable<void> process_notification(const DoutPrefixProvider* dpp,
@@ -467,7 +467,7 @@ public:
   int add_entry(const DoutPrefixProvider *dpp,
 		const RGWBucketInfo& bucket_info,
 		const rgw::bucket_log_layout_generation& gen,
-		int shard_id, optional_yield y);
+		int shard_id, optional_yield y) noexcept;
   int get_log_shard_id(rgw_bucket& bucket, int shard_id);
   asio::awaitable<std::tuple<std::vector<rgw_data_change_log_entry>,
 			     std::string, bool>>